Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hir::Node helper methods instead of repeating the same impl multiple times #122021

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Use hir::Node helper methods instead of repeating the same impl multiple times #122021

merged 2 commits into from
Mar 19, 2024

Commits on Mar 18, 2024

  1. Deduplicate associated_body and body_id 

    They match on almost the same patterns, which is fishy.

Also turn `associated_body` into a method and do some cleanups nearby the call sites
    @oli-obk
    oli-obk committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    419d205 View commit details
    Browse the repository at this point in the history

  2. Use hir::Node helper methods instead of repeat the same impl multip… 

    …le times

There already were inconsistencies, so this ensures we don't introduce subtle surprising bugs
    @oli-obk
    oli-obk committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    69c4e81 View commit details
    Browse the repository at this point in the history