Skip to content

Conversation

ibraheemdev
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 26, 2024
@ChrisDenton
Copy link
Member

The queue looks relatively light (once the current rollup is done) so I'll boost this one to the top

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 26, 2024

📌 Commit 580b003 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2024
@bors
Copy link
Collaborator

bors commented Feb 26, 2024

⌛ Testing commit 580b003 with merge fc3800f...

@klensy
Copy link
Contributor

klensy commented Feb 26, 2024

Needs beta backport?

@ChrisDenton ChrisDenton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 26, 2024
@bors
Copy link
Collaborator

bors commented Feb 26, 2024

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing fc3800f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 26, 2024
@bors bors merged commit fc3800f into rust-lang:master Feb 26, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 26, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fc3800f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.1% [3.8%, 4.4%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [-1.7%, 4.4%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [1.6%, 1.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.626s -> 651.881s (0.19%)
Artifact size: 311.12 MiB -> 311.16 MiB (0.01%)

@m-ou-se
Copy link
Member

m-ou-se commented Feb 28, 2024

We don't usually backport fixes for non-critical bugs that have already been around for a while on stable.

@m-ou-se m-ou-se removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 28, 2024
@m-ou-se
Copy link
Member

m-ou-se commented Feb 28, 2024

We briefly discussed this in the libs team meeting. We didn't have consenesus on backporting this, due to the bug already being around for a long time on stable and the low severity of the bug (a memory leak).

@ibraheemdev
Copy link
Member Author

The race occurs if the receiver half of an empty channel is dropped while a sender is trying to send, which is not very likely. I don't think this needs to be backported.

jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 29, 2024
Document potential memory leak in unbounded channel

Follow up on rust-lang#121646.
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 29, 2024
Document potential memory leak in unbounded channel

Follow up on rust-lang#121646.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 29, 2024
Rollup merge of rust-lang#121778 - ibraheemdev:patch-19, r=RalfJung

Document potential memory leak in unbounded channel

Follow up on rust-lang#121646.
petrosagg added a commit to petrosagg/rust that referenced this pull request Apr 11, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg added a commit to petrosagg/rust that referenced this pull request Apr 11, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg added a commit to petrosagg/rust that referenced this pull request Apr 11, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg added a commit to petrosagg/rust that referenced this pull request Apr 11, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 17, 2025
…alfJung,tgross35

sync::mpsc: prevent double free on `Drop`

This PR is fixing a regression introduced by rust-lang#121646 that can lead to a double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR crossbeam-rs/crossbeam#1187
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 17, 2025
…alfJung,tgross35

sync::mpsc: prevent double free on `Drop`

This PR is fixing a regression introduced by rust-lang#121646 that can lead to a double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR crossbeam-rs/crossbeam#1187
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 18, 2025
…alfJung,tgross35

sync::mpsc: prevent double free on `Drop`

This PR is fixing a regression introduced by rust-lang#121646 that can lead to a double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR crossbeam-rs/crossbeam#1187
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2025
Rollup merge of rust-lang#139553 - petrosagg:channel-double-free, r=RalfJung,tgross35

sync::mpsc: prevent double free on `Drop`

This PR is fixing a regression introduced by rust-lang#121646 that can lead to a double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR crossbeam-rs/crossbeam#1187
cuviper pushed a commit to cuviper/rust that referenced this pull request Apr 18, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
(cherry picked from commit b9e2ac5)
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
…alfJung,tgross35

sync::mpsc: prevent double free on `Drop`

This PR is fixing a regression introduced by rust-lang#121646 that can lead to a double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR crossbeam-rs/crossbeam#1187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Occasional memory leak in mpsc channels

8 participants