always run configure_linker except for mir-opt tests

[onur-ozkan]

configure_linker now runs consistently unless it's for mir-opt tests. Previously != "check" condition was causing dirt in the cargo cache between runs of x anything-but-not-check and x check.

Fixes #120768

cc @saethlin

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or
reassign to another reviewer.

Use r? to explicitly pick a reviewer

[saethlin]

I've tried this out and it seems to work.

I'd love to see a cleaner signature for Builder::cargo in the future, but I'm happy to see any fix for this so quickly. Thanks!

[onur-ozkan]

I'd love to see a cleaner signature for Builder::cargo in the future

This is definetly on my to-do plans.

[onur-ozkan]

Made some refactoring to how we handle linker configuration in Builder::cargo. I think it looks okay overall, but the downside is that we have to configure the linker manually when needed. Any thoughts? @RalfJung @saethlin

[RalfJung]

Seems too easy now to just forget calling configure_linker -- it's what you need in most cases, after all.

[onur-ozkan]

the downside is that we have to configure the linker manually when needed. Any thoughts?

We don't do this anymore. Builder::cargo is now private, and we use these new functions instead: https://github.com/onur-ozkan/rust/blob/3c019de0febceeed9432813c8dfd39280b244d5c/src/bootstrap/src/core/builder.rs#L2240-L2264.

[RalfJung]

The approach makes sense to me, sadly I can't confidently review bootstrap changes.

@rust-lang/bootstrap would be good to land this rather quickly, this is fixing an issue that currently extends the edit-compile-test cycle for some cases from <1s to >1min.

[Mark-Simulacrum]

@bors r+ rollup=iffy

[bors]

📌 Commit ff6d296 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[RalfJung]

This is fixing a rustc development roadblock.
@bors p=1

[bors]

⌛ Testing commit ff6d296 with merge 1a648b3...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1a648b3 to master...

[rust-timer]

Finished benchmarking commit (1a648b3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.9%	[-3.9%, -3.9%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.7%, -1.0%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.4%	[-1.7%, -1.0%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.94s -> 664.283s (-0.10%)
Artifact size: 308.28 MiB -> 308.29 MiB (0.01%)