Skip to content

GVN: also turn moves into copies with projections #120688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2024
Merged

GVN: also turn moves into copies with projections #120688

merged 2 commits into from
Feb 8, 2024

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Feb 5, 2024

Fixes #120613

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 5, 2024
@cjgillot cjgillot added the A-mir-opt Area: MIR optimizations label Feb 5, 2024
@workingjubilee
Copy link
Member

#120690

r? compiler

@rustbot rustbot assigned wesleywiser and unassigned b-naber Feb 6, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Feb 6, 2024

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 6, 2024

📌 Commit 6fbd761 has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned wesleywiser Feb 6, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2024
This was referenced Feb 7, 2024
Closed
Closed
Merged
@bors bors merged commit 65aa9ea into rust-lang:master Feb 8, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 8, 2024
@cjgillot cjgillot deleted the gvn-partial-move branch February 8, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-mir-opt Area: MIR optimizations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

GVN causes moved function arguments to be used again
7 participants
@cjgillot @rustbot @workingjubilee @oli-obk @bors @wesleywiser @b-naber