Skip to content

Make unsafe_op_in_unsafe_fn migrated in edition 2024 #119948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

Make unsafe_op_in_unsafe_fn migrated in edition 2024 #119948

merged 1 commit into from
Jan 22, 2024

Conversation

@asquared31415
Copy link
Contributor

fixes #119823

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2024
@asquared31415
Copy link
Contributor Author

@rustbot label +A-lint +A-edition-2024 +F-unsafe-block-in-unsafe-fn

@rustbot rustbot added A-edition-2024 Area: The 2024 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. F-unsafe-block-in-unsafe-fn RFC #2585 labels Jan 13, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jan 15, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2024
@rust-cloud-vms rust-cloud-vms bot force-pushed the unsafe_op_in_unsafe_fn_fix branch from 8ef7d1a to 0608661 Compare January 15, 2024 22:41
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the unsafe_op_in_unsafe_fn_fix branch from 0608661 to a8bb418 Compare January 15, 2024 23:06
@asquared31415
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2024
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jan 21, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 21, 2024

📌 Commit a8bb418 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Jan 21, 2024
@TaKO8Ki
Rollup merge of rust-lang#119948 - asquared31415:unsafe_op_in_unsafe_…
ec6b57d 
…fn_fix, r=TaKO8Ki

Make `unsafe_op_in_unsafe_fn` migrated in edition 2024

fixes rust-lang#119823
@TaKO8Ki TaKO8Ki mentioned this pull request Jan 21, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2024
@bors
Auto merge of rust-lang#120209 - TaKO8Ki:rollup-sicsyig, r=TaKO8Ki
8ace346 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#118639 (Undeprecate lint `unstable_features` and make use of it in the compiler)
 - rust-lang#118714 ( Explanation that fields are being used when deriving `(Partial)Ord` on enums)
 - rust-lang#119801 (Fix deallocation with wrong allocator in (A)Rc::from_box_in)
 - rust-lang#119948 (Make `unsafe_op_in_unsafe_fn` migrated in edition 2024)
 - rust-lang#119999 (remote-test: use u64 to represent file size)
 - rust-lang#120058 (bootstrap: improvements for compiler builds)
 - rust-lang#120160 (Manually implement derived `NonZero` traits.)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120194 (Shorten `#[must_use]` Diagnostic Message for `Option::is_none`)
 - rust-lang#120200 (Correct the anchor of an URL in an error message)
 - rust-lang#120203 (Replace `#!/bin/bash` with `#!/usr/bin/env bash` in rust-installer tests)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#119948 - asquared31415:unsafe_op_in_unsafe_…
80678b6 
…fn_fix, r=TaKO8Ki

Make `unsafe_op_in_unsafe_fn` migrated in edition 2024

fixes rust-lang#119823
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#119948 - asquared31415:unsafe_op_in_unsafe_…
55a0337 
…fn_fix, r=TaKO8Ki

Make `unsafe_op_in_unsafe_fn` migrated in edition 2024

fixes rust-lang#119823
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2024
@bors
Auto merge of rust-lang#120239 - matthiaskrgr:rollup-vqjn6ot, r=matth…
021861a 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#118578 (core: introduce split_at{,_mut}_checked)
 - rust-lang#119369 (exclude unexported macro bindings from extern crate)
 - rust-lang#119408 (xous: misc fixes + add network support)
 - rust-lang#119943 (std::net: bind update for using backlog as `-1` too.)
 - rust-lang#119948 (Make `unsafe_op_in_unsafe_fn` migrated in edition 2024)
 - rust-lang#119999 (remote-test: use u64 to represent file size)
 - rust-lang#120152 (add help message for `exclusive_range_pattern` error)
 - rust-lang#120213 (Don't actually make bound ty/const for RTN)
 - rust-lang#120225 (Fix -Zremap-path-scope typo)

Failed merges:

 - rust-lang#119972 (Add `ErrCode`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 34bab29 into rust-lang:master Jan 22, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2024
@rust-timer
Unrolled build for rust-lang#119948
9a6a7db 
Rollup merge of rust-lang#119948 - asquared31415:unsafe_op_in_unsafe_fn_fix, r=TaKO8Ki

Make `unsafe_op_in_unsafe_fn` migrated in edition 2024

fixes rust-lang#119823
@traviscross traviscross mentioned this pull request Jun 4, 2024
Closed
7 tasks
@asquared31415 asquared31415 deleted the unsafe_op_in_unsafe_fn_fix branch December 3, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TaKO8Ki TaKO8Ki

Labels

A-edition-2024 Area: The 2024 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. F-unsafe-block-in-unsafe-fn RFC #2585 S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.77.0

Development

Successfully merging this pull request may close these issues.

Make unsafe_op_in_unsafe_fn auto-migrated in 2024 edition

5 participants

@asquared31415 @rustbot @rust-log-analyzer @TaKO8Ki @bors