Simplify bootstrap --check-cfg arguments

[Urgau]

This PR simplifies the generated check-cfg arguments generated for the no-values case.

For the bootstrap cfg:

- --check-cfg=cfg(bootstrap,values())
+ --check-cfg=cfg(bootstrap)

Those are equivalent, so there isn't any semantic difference; but the invocation is shorter and less distracting.

@rustbot label +F-check-cfg

[rustbot]

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

[onur-ozkan]

If we making changes here I expect seperating the logic and write unit tests on it.

[Urgau]

If we making changes here I expect seperating the logic and write unit tests on it.

Sure, and were should the function and it's unit-test be?

[onur-ozkan]

Sure, and were should the function and it's unit-test be?

I think function can be right below EXTRA_CHECK_CFGS in lib.rs, and tests can be under tests/builder.rs

[Urgau]

@onur-ozkan After looking at similar functions I move the logic to helpers.rs and added some unit-tests under tests/helpers.rs.

[onur-ozkan]

LGTM, r=me with or without the suggestion

[Urgau]

LGTM, r=me with or without the suggestion

👍 but I don't have a r+ rights 😅

[onur-ozkan]

@bors r+

[bors]

📌 Commit a236bdd has been approved by onur-ozkan

It is now in the queue for this repository.

[bors]

⌛ Testing commit a236bdd with merge fcfe05a...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing fcfe05a to master...

[rust-timer]

Finished benchmarking commit (fcfe05a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.357s -> 667.255s (-0.16%)
Artifact size: 311.73 MiB -> 311.75 MiB (0.01%)