Simplify source pages sidebar handling#119016
Simplify source pages sidebar handling#119016GuillaumeGomez wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
rustbot
added
the
T-rustdoc
| #src-sidebar div.files > a.selected { | ||
| background-color: var(--src-sidebar-background-selected); | ||
| } | ||
| #src-sidebar-toggle > button { |
There was a problem hiding this comment.
I moved the block just under #src-sidebar-toggle rule as it made more sense like this.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
simplify-src-sidebar-js
branch
from
c310228 to
ac97299
Compare
| content: ">"; | ||
| } | ||
| .src-sidebar-expanded #src-sidebar-toggle > button::before { | ||
| content: "<"; |
There was a problem hiding this comment.
Didn’t we reduce using generated content for accessibility reasons?
There was a problem hiding this comment.
We absolutely did. The other possibility is to have two buttons. I'll go with this option then.
There was a problem hiding this comment.
Could it be switched to <details>?
There was a problem hiding this comment.
Yes but I thought for accessibility reasons we didn't want to do that haha.
GuillaumeGomez
force-pushed
the
simplify-src-sidebar-js
branch
from
ac97299 to
e9faeea
Compare
|
Updated the JS by having two buttons instead of just one. |
|
☔ The latest upstream changes (presumably #119066) made this pull request unmergeable. Please resolve the merge conflicts. |
5 participants
Since the text isn't really important in itself, instead of updating it manually in the JS, we can let the CSS do it instead.
r? @notriddle