Rollup of 4 pull requests #118543
Merged
Rollup of 4 pull requests #118543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Retrieve `FnSig`. - Implement CrateDef for InstanceDef. - Add VTable index for Virtual instances.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
rustc_hir_typeck: Fix ICE when probing for non-ASCII function alternative Closes rust-lang#118499 Apparently triggered by rust-lang#118381
Add more information to StableMIR Instance Allow stable MIR users to retrieve an instance function signature, the index for a VTable instance and more information about its underlying definition. These are needed to properly interpret function calls, either via VTable or direct calls. The `CrateDef` implementation will also allow users to emit diagnostic messages. I also fixed a few issues that we had identified before with how we were retrieving body of things that may not have a body available.
…ubby789 replace `once_cell::sync::OnceCell` with std `OnceLock` > https://github.com/rust-lang/rust/blob/0919ad18381f6f4fcaddc809e786553e028bbde0/src/bootstrap/src/core/builder.rs#L28-L33 Partially resolves that.
move packed-struct tests into packed/ folder We already have a bunch of other tests named `packed/packed-struct*`, no reason to have these two tests be separate.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=4 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 4e3dc976e7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 2, 2023
|
Finished benchmarking commit (0908f17): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.421s -> 670.8s (-0.39%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
once_cell::sync::OnceCellwith stdOnceLock#118528 (replaceonce_cell::sync::OnceCellwith stdOnceLock)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup