Add support for making lib features internal #118123

RalfJung · 2023-11-21T07:07:45Z

We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug.

This extends that idea to lib features as well. It is an alternative to #115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in _internals or _internal is considered internal.

Then we rename core_intrinsics to core_intrinsics_internal, which fixes #115597.

rustbot · 2023-11-21T07:07:55Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-21T07:07:58Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

RalfJung · 2023-11-21T07:09:24Z

@Amanieu it looks like stdarch is using the core_intrinsics feature, so the build will fail here. What is the best way to change this feature name?

(Submodules are so painful. I hope we can transition everything to subtrees eventually...)

RalfJung · 2023-11-21T07:10:52Z

compiler/rustc_feature/src/unstable.rs

@@ -207,9 +216,6 @@ declare_features! (
    (internal, test_2018_feature, "1.31.0", None, Some(Edition::Edition2018)),
    /// Added for testing unstable lints; perma-unstable.
    (internal, test_unstable_lint, "1.60.0", None, None),
-    /// Allows non-`unsafe` —and thus, unsound— access to `Pin` constructions.
-    /// Marked `internal` since perma-unstable and unsound.
-    (internal, unsafe_pin_internals, "1.60.0", None, None),


This is a libs feature that was added here solely to make it "incomplete" (c93968a), and then later "internal". That's not needed any more.

RalfJung · 2023-11-21T07:26:28Z

Turns out it's not very hard to avoid using this feature in stdarch, so rust-lang/stdarch#1500 should let us do this transition.

RalfJung · 2023-11-21T08:56:22Z

Oh, turns out the build failure here is from compiler-builtins, not stdarch. stdarch is fine since it is not a separate crate.

EDIT: PR filed: rust-lang/compiler-builtins#557

RalfJung · 2023-11-22T06:31:32Z

As suggested by @Nilstrieb, instead of trying to rename core_intrinsics I just added that to the list of internal features now. It's a hack, but it avoids the hassle of having to rename this feature, which is used all over the low-level parts of the standard library.

rustbot · 2023-11-22T19:01:05Z

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

RalfJung · 2023-11-27T08:24:25Z

core_panic looks like another feature that should be covered by this. If the PR gets accepted, we should probably rename it to core_panic_internals.

RalfJung · 2023-12-02T18:08:35Z

2 weeks without hearing from the reviewer, let me re-roll the dice.
r? compiler

compiler-errors · 2023-12-05T16:44:03Z

Thanks @RalfJung, this is great

@bors r+

bors · 2023-12-05T16:44:06Z

📌 Commit 74834a9 has been approved by compiler-errors

It is now in the queue for this repository.

…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#117793 (Update variable name to fix `unused_variables` warning) - rust-lang#118123 (Add support for making lib features internal) - rust-lang#118268 (Pretty print `Fn<(..., ...)>` trait refs with parentheses (almost) always) - rust-lang#118346 (Add `deeply_normalize_for_diagnostics`, use it in coherence) - rust-lang#118350 (Simplify Default for tuples) - rust-lang#118450 (Use OnceCell in cell module documentation) - rust-lang#118585 (Fix parser ICE when recovering `dyn`/`impl` after `for<...>`) - rust-lang#118587 (Cleanup error handlers some more) - rust-lang#118642 (bootstrap(builder.rs): Don't explicitly warn against `semicolon_in_expressions_from_macros`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.

This is due to rust-lang/rust#118123

…8472 merge core_panic feature into panic_internals I don't know why those are two separate features, but it does not seem intentional. This merge is useful because with rust-lang#118123, panic_internals is recognized as an internal feature, but core_panic is not -- but core_panic definitely should be internal.

Rollup merge of rust-lang#118781 - RalfJung:core-panic-feature, r=the8472 merge core_panic feature into panic_internals I don't know why those are two separate features, but it does not seem intentional. This merge is useful because with rust-lang#118123, panic_internals is recognized as an internal feature, but core_panic is not -- but core_panic definitely should be internal.

lib features ending in '_internals?' are internal

d1583eb

rustbot assigned wesleywiser Nov 21, 2023