Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline Linker #117993

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Streamline Linker #117993

merged 6 commits into from
Nov 17, 2023

Conversation

nnethercote
Copy link
Contributor

r? @bjorn3

@nnethercote
Copy link
Contributor Author

Best reviewed one commit at a time.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2023
@nnethercote
Streamline Queries::linker.
3560122
@nnethercote
Move Session out of Linker.
de91b6d 
It can easily be passed in. And that removes the single clone of
`Compiler::session`, which means it no longer needs to be `Lrc`.
@nnethercote
Move CodegenBackend out of Linker.
aed8e1f 
It can easily be passed in. And that removes the single clone of
`Compiler::codegen_backend`, which means it no longer needs to be `Lrc`.
@nnethercote
Rename Linker::prepare_outputs as output_filenames.
94c9075 
It matches the type, and a noun makes more sense than a verb.

The `output_filenames` function still uses a profiling label named
`prepare_outputs`, but I think that makes sense as a verb and can be
left unchanged.
@nnethercote
Remove a low-value local variable.
4a57b80
@nnethercote
Make Compiler::sess private.
9582172 
Like `Compiler::codegen_backend`.
@bjorn3
Copy link
Member

bjorn3 commented Nov 17, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 17, 2023

📌 Commit 9582172 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2023
@bjorn3 bjorn3 mentioned this pull request Nov 17, 2023
Merged
@bors
Copy link
Contributor

bors commented Nov 17, 2023

⌛ Testing commit 9582172 with merge e886137...

@bors
Copy link
Contributor

bors commented Nov 17, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing e886137 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2023
@bors bors merged commit e886137 into rust-lang:master Nov 17, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
This was referenced Nov 17, 2023
Merged
Merged
@nnethercote nnethercote deleted the streamline-Linker branch November 17, 2023 20:14
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e886137): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 0.9%] 4
Regressions ❌
(secondary)		 3.2% [0.7%, 14.1%] 8
Improvements ✅
(primary)		 -2.0% [-3.9%, -1.0%] 3
Improvements ✅
(secondary)		 -3.3% [-5.7%, -1.5%] 7
All ❌✅ (primary) -0.5% [-3.9%, 0.9%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 -3.7% [-5.9%, -2.0%] 8
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.162s -> 674.246s (-0.28%)
Artifact size: 313.62 MiB -> 313.61 MiB (-0.00%)

@nnethercote nnethercote mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @bjorn3 @bors @rust-timer @rustbot