Set CFG_OMIT_GIT_HASH=1 during builds when omit-git-hash is enabled
#117868
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ We should consider whether this should be a proper Cargo feature at some point (e.g., https://doc.rust-lang.org/nightly/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates having a CARGO_CRATE_GIT_HASH or so), since otherwise I imagine there's some whack-a-mole here in theory. |
bors
added
S-waiting-on-bors
…-Simulacrum Set `CFG_OMIT_GIT_HASH=1` during builds when `omit-git-hash` is enabled This environment variable will allow tools like Cargo to disable their own detection when `omit-git-hash` is set to `true`. I created this PR because of rust-lang/cargo#12968. There is not a dependency between the two PRs, they can land in any order. They just won't do anything until both of them are merged into the repo.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (0d3dfb5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.495s -> 676.828s (0.35%) |
This environment variable will allow tools like Cargo to disable their own detection when
omit-git-hashis set totrue.I created this PR because of rust-lang/cargo#12968. There is not a dependency between the two PRs, they can land in any order. They just won't do anything until both of them are merged into the repo.