Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: do not purge docs on CI environment #117471

Merged
merged 1 commit into from
Nov 2, 2023
Merged

bootstrap: do not purge docs on CI environment #117471

merged 1 commit into from
Nov 2, 2023

Conversation

onur-ozkan
Copy link
Member

This is a temporary fix for #117430, for more information please read #117430 (comment).

Fixes #117430

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 31, 2023
@onur-ozkan
Copy link
Member Author

r? Mark-Simulacrum

@rustbot rustbot assigned Mark-Simulacrum and unassigned clubby789 Oct 31, 2023
onur-ozkan
onur-ozkan commented Oct 31, 2023
View reviewed changes
src/bootstrap/src/core/builder.rs Outdated
@@ -1273,7 +1274,7 @@ impl<'a> Builder<'a> {
self.clear_if_dirty(&out_dir, &backend);
}

if cmd == "doc" || cmd == "rustdoc" {
if cmd == "doc" || cmd == "rustdoc" && !CiEnv::is_ci() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't cause any problem? I assume that the runners are automatically purging the entire build related state upon the termination.

@onur-ozkan onur-ozkan mentioned this pull request Nov 2, 2023
Closed
@onur-ozkan
Copy link
Member Author

onur-ozkan commented Nov 2, 2023 •
edited
Loading

As this PR resolves quite important bug, please feel free to review and r+ if changes looks good.

cc @rust-lang/bootstrap @rust-lang/infra

@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2023

📌 Commit d991f7c has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2023
@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

@bors p=1
we should get the nightly rustc docs fixed ASAP

@bors
Copy link
Contributor

bors commented Nov 2, 2023

⌛ Testing commit d991f7c with merge c02acd1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2023
@bors
Auto merge of rust-lang#117471 - onur-ozkan:tmp-fix, r=clubby789
c02acd1 
bootstrap: do not purge docs on CI environment

This is a temporary fix for rust-lang#117430, for more information please read rust-lang#117430 (comment).

Fixes rust-lang#117430
@bors
Copy link
Contributor

bors commented Nov 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
Copy link
Member Author

error parsing HTTP 429 response body: invalid character 'T' looking for beginning of value: "Too Many Requests (HAP429).\n"

@bors retry p=1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2023
@bors
Copy link
Contributor

bors commented Nov 2, 2023

⌛ Testing commit d991f7c with merge 92752a1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2023
@bors
Auto merge of rust-lang#117471 - onur-ozkan:tmp-fix, r=clubby789
92752a1 
bootstrap: do not purge docs on CI environment

This is a temporary fix for rust-lang#117430, for more information please read rust-lang#117430 (comment).

Fixes rust-lang#117430
@bors
Copy link
Contributor

bors commented Nov 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2023
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2023
@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

This looks systematic, let's close the tree.
@bors treeclosed=100

Cc @rust-lang/infra

@bors bors mentioned this pull request Nov 2, 2023
Merged
@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

Hm, but strangely no other PR seems affected?
both this and this didn't have this issue (they failed, but elsewhere and later), and #117521 also seems fine. And https://www.dockerstatus.com/ claims that everything is fine on the docker side.

@onur-ozkan
Copy link
Member Author

I have no idea, let me rebase the latest upstream and let's give another shot then?

@onur-ozkan
bootstrap: do not purge docs on CI environment
6198e88 
Temporary fix for rust-lang#117430

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

@bors treeclosed-

@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

@bors r=clubby789

@bors
Copy link
Contributor

bors commented Nov 2, 2023

📌 Commit 6198e88 has been approved by clubby789

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 2, 2023

⌛ Testing commit 6198e88 with merge e8418e0...

@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2023

Now I am also seeing it in other jobs. Seems to be an on-and-off thing.

@bors
Copy link
Contributor

bors commented Nov 2, 2023

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing e8418e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2023
@bors bors merged commit e8418e0 into rust-lang:master Nov 2, 2023
12 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Nov 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e8418e0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 637.769s -> 636.864s (-0.14%)
Artifact size: 304.51 MiB -> 304.51 MiB (-0.00%)

@github-actions github-actions bot mentioned this pull request Nov 3, 2023
Merged
@RalfJung
Copy link
Member

RalfJung commented Nov 3, 2023

@onur-ozkan so you are saying this did not help? Should we revert it?

@onur-ozkan
Copy link
Member Author

@onur-ozkan so you are saying this did not help? Should we revert it?

Yes, we should.

@onur-ozkan onur-ozkan mentioned this pull request Nov 3, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 3, 2023
@bors-ferrocene @nnethercote
@roblabla @compiler-errors @massivebird @bors @Zalathar @lcnr @joshlf @matthiaskrgr
Merge #82
a76df3b 
82: Automated pull from upstream `master` r=tshepang a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#117313
* rust-lang/rust#117131
* rust-lang/rust#117134
* rust-lang/rust#117471
* rust-lang/rust#117521
* rust-lang/rust#117513
  * rust-lang/rust#117512
  * rust-lang/rust#117509
  * rust-lang/rust#117495
  * rust-lang/rust#117394
* rust-lang/rust#117466
* rust-lang/rust#117204
* rust-lang/rust#117386
* rust-lang/rust#117506



Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com>
Co-authored-by: roblabla <unfiltered@roblab.la>
Co-authored-by: Michael Goulet <michael@errs.io>
Co-authored-by: massivebird <gdrakemail@gmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
Co-authored-by: lcnr <rust@lcnr.de>
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 3, 2023
@matthiaskrgr
Rollup merge of rust-lang#117533 - onur-ozkan:revert-117471, r=onur-o…
c0fa97c 
…zkan

Revert "bootstrap: do not purge docs on CI environment"

This reverts commit 6198e88.

ref rust-lang#117430 (comment), rust-lang#117471 (comment)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2023
@rust-timer
Unrolled build for rust-lang#117533
72d317a 
Rollup merge of rust-lang#117533 - onur-ozkan:revert-117471, r=onur-ozkan

Revert "bootstrap: do not purge docs on CI environment"

This reverts commit 6198e88.

ref rust-lang#117430 (comment), rust-lang#117471 (comment)
@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2023 •
edited
Loading

visiting for perf-triage

@onur-ozkan onur-ozkan deleted the tmp-fix branch January 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.

CI: Bootstrap no longer documents compiler crates
9 participants
@onur-ozkan @rustbot @clubby789 @bors @RalfJung @rust-log-analyzer @rust-timer @pnkfelix @Mark-Simulacrum