Fix missing leading space in suggestion #117395

gurry · 2023-10-30T13:37:46Z

For a local pattern with no space between let and ( e.g.:

  let(_a) = 3;

we were previously suggesting this illegal code:

  let_a = 3;

After this change the suggestion will instead be:

  let _a = 3;

Fixes #117380

For a local pattern with no space between `let` and `(` e.g.: let(_a) = 3; we were previously suggesting this illegal code: let_a =3; After this change the suggestion will instead be: let _a =3; (Note the space after `let`)

rustbot · 2023-10-30T13:37:54Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_lint/src/unused.rs

Noratrieb · 2023-10-30T14:26:41Z

r? Nilstrieb
@bors r+ rollup
looks reasonable to me

bors · 2023-10-30T14:26:44Z

📌 Commit a2486db has been approved by Nilstrieb

It is now in the queue for this repository.

…Nilstrieb Fix missing leading space in suggestion For a local pattern with no space between `let` and `(` e.g.: ```rust let(_a) = 3; ``` we were previously suggesting this illegal code: ```rust let_a = 3; ``` After this change the suggestion will instead be: ```rust let _a = 3; ``` Fixes rust-lang#117380

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117317 (share some track_caller logic between interpret and codegen) - rust-lang#117357 (Rename a few remaining references to abort terminator) - rust-lang#117383 (improve and fix `x install`) - rust-lang#117389 (Some diagnostics improvements of `gen` blocks) - rust-lang#117390 (Fix unused variables lint issue for args in macro) - rust-lang#117395 (Fix missing leading space in suggestion) - rust-lang#117396 (Don't treat closures/coroutine types as part of the public API) r? `@ghost` `@rustbot` modify labels: rollup

…Nilstrieb Fix missing leading space in suggestion For a local pattern with no space between `let` and `(` e.g.: ```rust let(_a) = 3; ``` we were previously suggesting this illegal code: ```rust let_a = 3; ``` After this change the suggestion will instead be: ```rust let _a = 3; ``` Fixes rust-lang#117380

…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#112463 (rustdoc: elide cross-crate default generic arguments) - rust-lang#117068 (Clean up `compiler/rustc*/Cargo.toml`) - rust-lang#117132 (On object safety error, mention new enum as alternative) - rust-lang#117317 (share some track_caller logic between interpret and codegen) - rust-lang#117356 (Add support for mipsel-unknown-netbsd, 32-bit LE mips.) - rust-lang#117357 (Rename a few remaining references to abort terminator) - rust-lang#117370 (C-variadic error improvements) - rust-lang#117376 (More `rustc_interface` cleanups) - rust-lang#117383 (improve and fix `x install`) - rust-lang#117390 (Fix unused variables lint issue for args in macro) - rust-lang#117395 (Fix missing leading space in suggestion) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117395 - gurry:117380-wrong-parent-sugg, r=Nilstrieb Fix missing leading space in suggestion For a local pattern with no space between `let` and `(` e.g.: ```rust let(_a) = 3; ``` we were previously suggesting this illegal code: ```rust let_a = 3; ``` After this change the suggestion will instead be: ```rust let _a = 3; ``` Fixes rust-lang#117380

Fix missing leading space in suggestion

a2486db

For a local pattern with no space between `let` and `(` e.g.: let(_a) = 3; we were previously suggesting this illegal code: let_a =3; After this change the suggestion will instead be: let _a =3; (Note the space after `let`)

rustbot assigned b-naber Oct 30, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2023

Noratrieb reviewed Oct 30, 2023

View reviewed changes

compiler/rustc_lint/src/unused.rs Show resolved Hide resolved

rustbot assigned Noratrieb Oct 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

rustbot unassigned b-naber Oct 30, 2023

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117400

Closed

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117402

Closed

GuillaumeGomez mentioned this pull request Oct 30, 2023

Rollup of 12 pull requests #117404

Closed

GuillaumeGomez mentioned this pull request Oct 30, 2023

Rollup of 11 pull requests #117405

Merged

bors merged commit 9e4ab9f into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

gurry deleted the 117380-wrong-parent-sugg branch October 31, 2023 01:33

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing leading space in suggestion #117395

Fix missing leading space in suggestion #117395

gurry commented Oct 30, 2023 •

edited

Loading

rustbot commented Oct 30, 2023

Noratrieb commented Oct 30, 2023

bors commented Oct 30, 2023

Fix missing leading space in suggestion #117395

Fix missing leading space in suggestion #117395

Conversation

gurry commented Oct 30, 2023 • edited Loading

rustbot commented Oct 30, 2023

Noratrieb commented Oct 30, 2023

bors commented Oct 30, 2023

gurry commented Oct 30, 2023 •

edited

Loading