Enable MIR JumpThreading by default #117206

cjgillot · 2023-10-26T07:08:58Z

Mostly for perf

r? @ghost

cjgillot · 2023-10-26T07:12:28Z

@bors try @rust-timer queue

bors · 2023-10-26T07:13:38Z

⌛ Trying commit ada7a64 with merge ba11b7d...

…try> PERF: Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

cjgillot · 2023-10-26T10:05:07Z

@bors try @rust-timer queue

bors · 2023-10-26T10:06:16Z

⌛ Trying commit a7ccf80 with merge 3c05740...

…try> PERF: Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

bors · 2023-10-26T11:28:46Z

☀️ Try build successful - checks-actions
Build commit: 3c05740 (3c057402b0189299d625a97e4787287ea0fe75cf)

rust-timer · 2023-10-26T18:00:21Z

Finished benchmarking commit (3c05740): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.5%, 3.5%]	8
Regressions ❌ (secondary)	1.4%	[0.1%, 3.7%]	16
Improvements ✅ (primary)	-0.5%	[-0.9%, -0.2%]	144
Improvements ✅ (secondary)	-0.6%	[-2.5%, -0.1%]	58
All ❌✅ (primary)	-0.4%	[-0.9%, 3.5%]	152

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[0.2%, 5.3%]	5
Regressions ❌ (secondary)	3.0%	[1.3%, 3.8%]	4
Improvements ✅ (primary)	-3.6%	[-3.6%, -3.6%]	1
Improvements ✅ (secondary)	-2.8%	[-3.7%, -1.8%]	2
All ❌✅ (primary)	2.2%	[-3.6%, 5.3%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.1%, 1.7%]	2
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.3%]	2
Improvements ✅ (secondary)	-5.9%	[-9.8%, -2.1%]	4
All ❌✅ (primary)	0.0%	[-1.4%, 1.7%]	4

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.0%, 1.7%]	76
Regressions ❌ (secondary)	0.4%	[0.1%, 0.5%]	77
Improvements ✅ (primary)	-0.5%	[-1.5%, -0.0%]	15
Improvements ✅ (secondary)	-0.6%	[-1.3%, -0.2%]	3
All ❌✅ (primary)	0.2%	[-1.5%, 1.7%]	91

Bootstrap: missing data
Artifact size: 304.42 MiB -> 304.79 MiB (0.12%)

…miasko Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

bors · 2024-02-10T14:43:22Z

⌛ Testing commit 014b29e with merge f0eaa2b...

rust-log-analyzer · 2024-02-10T15:50:55Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[117/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_thread.cpp.o
[118/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_interceptors.cpp.o
[119/119] Linking CXX shared library lib/darwin/libclang_rt.asan_ios_dynamic.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
-iphoneos_version_min has been renamed to -ios_version_min
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_allocator.cpp.o' has malformed LC_DYSYMTAB, expected 68 undefined symbols to start at index 211, found 65 undefined symbols starting at index 211
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_activation.cpp.o' has malformed LC_DYSYMTAB, expected 35 undefined symbols to start at index 51, found 32 undefined symbols starting at index 51
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_debugging.cpp.o' has malformed LC_DYSYMTAB, expected 26 undefined symbols to start at index 28, found 23 undefined symbols starting at index 28
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_descriptions.cpp.o' has malformed LC_DYSYMTAB, expected 51 undefined symbols to start at index 96, found 48 undefined symbols starting at index 96
---
[34/36] Building CXX object lib/tsan/rtl/CMakeFiles/clang_rt.tsan_ios_dynamic.dir/tsan_new_delete.cpp.o
[35/36] Building CXX object lib/tsan/rtl/CMakeFiles/clang_rt.tsan_ios_dynamic.dir/tsan_interceptors_libdispatch.cpp.o
[36/36] Linking CXX shared library lib/darwin/libclang_rt.tsan_ios_dynamic.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
-iphoneos_version_min has been renamed to -ios_version_min
 finished in 99.185 seconds
##[endgroup]
[TIMING] core::build_steps::llvm::Sanitizers { target: aarch64-apple-ios } -- 99.185
[TIMING] core::builder::Builder::sysroot_libdir::Libdir { compiler: Compiler { stage: 2, host: x86_64-apple-darwin }, target: aarch64-apple-ios } -- 0.000
---
-- Found assembler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
CMake Error at /usr/local/Cellar/cmake/3.28.2/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang - broken

    "/Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang"

  is not able to compile a simple test program.
  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-q54j5w'
    
    Run Build Command(s): /usr/local/bin/ninja -v cmTC_acea0
    [1/2] /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios   -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -MD -MT CMakeFiles/cmTC_acea0.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_acea0.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_acea0.dir/testCCompiler.c.o -c /Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-q54j5w/testCCompiler.c
    [2/2] : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_acea0.dir/testCCompiler.c.o -o cmTC_acea0   && :
    FAILED: cmTC_acea0 
    : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_acea0.dir/testCCompiler.c.o -o cmTC_acea0   && :
    clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
    ld: unknown options: -ios_simulator_version_min 
    clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    

  


  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:14 (project)


-- Configuring incomplete, errors occurred!
thread 'main' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.48/src/lib.rs:975:5:
command did not execute successfully, got: exit status: 1

build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bors · 2024-02-10T15:51:19Z

💔 Test failed - checks-actions

Mark-Simulacrum · 2024-02-10T15:55:29Z

@bors retry spurious apple failure

bors · 2024-02-10T20:11:46Z

⌛ Testing commit 014b29e with merge 7ea3e5c...

…miasko Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

rust-log-analyzer · 2024-02-10T21:18:03Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[117/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_thread.cpp.o
[118/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_interceptors.cpp.o
[119/119] Linking CXX shared library lib/darwin/libclang_rt.asan_ios_dynamic.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
-iphoneos_version_min has been renamed to -ios_version_min
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_debugging.cpp.o' has malformed LC_DYSYMTAB, expected 26 undefined symbols to start at index 28, found 23 undefined symbols starting at index 28
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_allocator.cpp.o' has malformed LC_DYSYMTAB, expected 68 undefined symbols to start at index 211, found 65 undefined symbols starting at index 211
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_descriptions.cpp.o' has malformed LC_DYSYMTAB, expected 51 undefined symbols to start at index 96, found 48 undefined symbols starting at index 96
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_activation.cpp.o' has malformed LC_DYSYMTAB, expected 35 undefined symbols to start at index 51, found 32 undefined symbols starting at index 51
---
[34/36] Building CXX object lib/tsan/rtl/CMakeFiles/clang_rt.tsan_ios_dynamic.dir/tsan_new_delete.cpp.o
[35/36] Building CXX object lib/tsan/rtl/CMakeFiles/clang_rt.tsan_ios_dynamic.dir/tsan_interceptors_libdispatch.cpp.o
[36/36] Linking CXX shared library lib/darwin/libclang_rt.tsan_ios_dynamic.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
-iphoneos_version_min has been renamed to -ios_version_min
 finished in 103.764 seconds
##[endgroup]
[TIMING] core::build_steps::llvm::Sanitizers { target: aarch64-apple-ios } -- 103.765
[TIMING] core::builder::Builder::sysroot_libdir::Libdir { compiler: Compiler { stage: 2, host: x86_64-apple-darwin }, target: aarch64-apple-ios } -- 0.001
---
-- Found assembler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
CMake Error at /usr/local/Cellar/cmake/3.28.2/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang - broken

    "/Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang"

  is not able to compile a simple test program.
  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-f0KaiW'
    
    Run Build Command(s): /usr/local/bin/ninja -v cmTC_e94c2
    [1/2] /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios   -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -MD -MT CMakeFiles/cmTC_e94c2.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_e94c2.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_e94c2.dir/testCCompiler.c.o -c /Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-f0KaiW/testCCompiler.c
    [2/2] : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_e94c2.dir/testCCompiler.c.o -o cmTC_e94c2   && :
    FAILED: cmTC_e94c2 
    : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_e94c2.dir/testCCompiler.c.o -o cmTC_e94c2   && :
    clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
    ld: unknown options: -ios_simulator_version_min 
    clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    

  


  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:14 (project)


-- Configuring incomplete, errors occurred!
thread 'main' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.48/src/lib.rs:975:5:
command did not execute successfully, got: exit status: 1

build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bors · 2024-02-10T21:18:35Z

💔 Test failed - checks-actions

cjgillot · 2024-02-10T21:23:19Z

@bors retry apple failure

bors · 2024-02-10T22:15:21Z

⌛ Testing commit 014b29e with merge 42752cb...

bors · 2024-02-11T00:26:37Z

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 42752cb to master...

rust-timer · 2024-02-11T02:18:48Z

Finished benchmarking commit (42752cb): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.4%, 7.1%]	10
Regressions ❌ (secondary)	1.0%	[0.4%, 3.3%]	18
Improvements ✅ (primary)	-0.5%	[-1.6%, -0.2%]	130
Improvements ✅ (secondary)	-0.8%	[-2.5%, -0.3%]	74
All ❌✅ (primary)	-0.4%	[-1.6%, 7.1%]	140

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.4%	[0.3%, 7.1%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.6%	[-9.8%, -1.5%]	4
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-0.1%	[-9.8%, 7.1%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[1.0%, 6.9%]	3
Regressions ❌ (secondary)	3.8%	[3.4%, 4.4%]	4
Improvements ✅ (primary)	-1.3%	[-1.7%, -0.9%]	2
Improvements ✅ (secondary)	-2.0%	[-2.4%, -1.6%]	3
All ❌✅ (primary)	1.4%	[-1.7%, 6.9%]	5

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.0%, 2.9%]	72
Regressions ❌ (secondary)	0.5%	[0.1%, 0.8%]	57
Improvements ✅ (primary)	-0.5%	[-1.8%, -0.3%]	22
Improvements ✅ (secondary)	-0.8%	[-1.5%, -0.1%]	37
All ❌✅ (primary)	0.3%	[-1.8%, 2.9%]	94

Bootstrap: 667.259s -> 666.058s (-0.18%)
Artifact size: 308.02 MiB -> 308.32 MiB (0.10%)

Kobzol · 2024-02-13T07:51:37Z

The wins outweight the losses here. Furthermore, the compiler is doing more work, which should result in better runtime performance, which also seems to be shown in the runtime benchmarks.

@rustbot label: +perf-regression-triaged

@cjgillot

cc @cjgillot @tmiasko This revert is based on the following report of a regression caused by this PR: rust-lang#121094 In accordance with the compiler team [revert policy], PRs that cause meaningful regressions should be reverted and re-landed once the regression has been fixed (and a regression test has been added, where appropriate). [revert policy]: https://forge.rust-lang.org/compiler/reviews.html#reverts Fear not! Regressions happen. Please rest assured that this does not represent a negative judgment of your contribution or ability to contribute positively to Rust in the future. We simply want to prioritize keeping existing use cases working, and keep the compiler more stable for everyone. r? compiler

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 26, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 26, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2023

Auto merge of rust-lang#117206 - cjgillot:jump-threading-default, r=<…

ba11b7d

…try> PERF: Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

cjgillot added the A-mir-opt Area: MIR optimizations label Oct 26, 2023

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2023

Auto merge of rust-lang#117206 - cjgillot:jump-threading-default, r=<…

3c05740

…try> PERF: Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 26, 2023

cjgillot force-pushed the jump-threading-default branch from a7ccf80 to 8aba543 Compare November 25, 2023 19:01

This comment has been minimized.

Sign in to view

cjgillot force-pushed the jump-threading-default branch 2 times, most recently from 2e2876a to c8c43cc Compare December 9, 2023 13:47

This comment was marked as resolved.

Sign in to view

cjgillot force-pushed the jump-threading-default branch 2 times, most recently from c3b8306 to 5a8dccb Compare December 24, 2023 13:05

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2024

Auto merge of rust-lang#117206 - cjgillot:jump-threading-default, r=t…

f0eaa2b

…miasko Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2024

Auto merge of rust-lang#117206 - cjgillot:jump-threading-default, r=t…

7ea3e5c

…miasko Enable MIR JumpThreading by default Mostly for perf r? `@ghost`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2024

bors merged commit 42752cb into rust-lang:master Feb 11, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Feb 11, 2024

cjgillot deleted the jump-threading-default branch February 11, 2024 01:15

tmandry mentioned this pull request Feb 14, 2024

Recent optimization broke async recursion in release mode #121094

Closed

erickt mentioned this pull request Feb 14, 2024

Reverts rust-lang/rust#117206 #121118

Closed

apiraino mentioned this pull request Apr 2, 2024

Inefficient compiler optimization between stable versions on nightly #123262

Open

tgross35 mentioned this pull request Jul 26, 2024

Jump threading MIR opt unsoundly uses bitpattern equality for floats #128243

Closed

clubby789 mentioned this pull request Oct 3, 2024

-Zmir-opt-level miscompiles code with panic #131195

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable MIR JumpThreading by default #117206

Enable MIR JumpThreading by default #117206

cjgillot commented Oct 26, 2023

cjgillot commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

cjgillot commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

rust-timer commented Oct 26, 2023

This comment has been minimized.

This comment was marked as resolved.

bors commented Feb 10, 2024

rust-log-analyzer commented Feb 10, 2024

bors commented Feb 10, 2024

Mark-Simulacrum commented Feb 10, 2024

bors commented Feb 10, 2024

rust-log-analyzer commented Feb 10, 2024

bors commented Feb 10, 2024

cjgillot commented Feb 10, 2024

bors commented Feb 10, 2024

bors commented Feb 11, 2024

rust-timer commented Feb 11, 2024

Kobzol commented Feb 13, 2024

Enable MIR JumpThreading by default #117206

Enable MIR JumpThreading by default #117206

Conversation

cjgillot commented Oct 26, 2023

cjgillot commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

cjgillot commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

bors commented Oct 26, 2023

This comment has been minimized.

rust-timer commented Oct 26, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

This comment has been minimized.

This comment was marked as resolved.

bors commented Feb 10, 2024

rust-log-analyzer commented Feb 10, 2024

bors commented Feb 10, 2024

Mark-Simulacrum commented Feb 10, 2024

bors commented Feb 10, 2024

rust-log-analyzer commented Feb 10, 2024

bors commented Feb 10, 2024

cjgillot commented Feb 10, 2024

bors commented Feb 10, 2024

bors commented Feb 11, 2024

rust-timer commented Feb 11, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Kobzol commented Feb 13, 2024