Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to rustc_ast_passes #117204

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Minor improvements to rustc_ast_passes #117204

merged 7 commits into from
Nov 2, 2023

Commits on Oct 30, 2023

  1. Streamline gate_feature_* macros. 

    The debug probably isn't useful, and assigning all the `$foo`
metavariables to `foo` variables is verbose and weird. Also, `$x:expr`
usually doesn't have a space after the `:`.
    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    bb3e09f View commit details
    Browse the repository at this point in the history

  2. Cover two more cases in the gate_doc macro.

    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    531b38a View commit details
    Browse the repository at this point in the history

  3. Use a slice pattern to neaten a condition.

    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    dcb72e7 View commit details
    Browse the repository at this point in the history

  4. Use if let to reduce some excessive indentation.

    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c88954e View commit details
    Browse the repository at this point in the history

  5. Rearrange the gate_feature_* macros.

    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    de17ec9 View commit details
    Browse the repository at this point in the history

  6. Fix a FIXME, by adding a gate_multi macro. 

    Note that this adds the `span.allows_unstable` checking that this case
previously lacked.
    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    499b309 View commit details
    Browse the repository at this point in the history

  7. Test the multispan case in tests.ui/bounds-lifetime.rs.

    @nnethercote
    nnethercote committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5b391b0 View commit details
    Browse the repository at this point in the history