Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #117126

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Rollup of 5 pull requests #117126

merged 11 commits into from
Oct 24, 2023

Commits on Oct 23, 2023

  1. fix typos in comments

    GoodDaisy committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0d780b1 View commit details
    Browse the repository at this point in the history
  2. Update books

    rustbot committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c1fb05c View commit details
    Browse the repository at this point in the history
  3. Naming nits

    compiler-errors committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8951342 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    269d5a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. remove change-id assertion in bootstrap test

    In the bootstrap test, the assertion of the change-id
    fails whenever we update the change-id next to a breaking change
    in build configurations. This commit removes the assertion,
    as it's not critical or useful to have.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b99b935 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    712106b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#117081 - GoodDaisy:master, r=wesleywiser

    fix typos in comments
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0aade2f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#117091 - compiler-errors:debug, r=lcnr

    `OptWithInfcx` naming nits, trait bound simplifications
    
    * Use an associated type `Interner` on `InferCtxtLike` to remove a redundant interner parameter (`I: Interner, Infcx: InferCtxtLike<I>` -> `Infcx: InferCtxtLike`).
    * Remove double-`Option` between `infcx: Option<Infcx>` and `fn universe_of_ty(&self, ty: ty::InferTy) -> Option<ty::UniverseIndex>`. We don't need the infcx to be optional if we can provide a "noop" (`NoInfcx`) implementation that just always returns `None` for universe index.
        * Also removes the `core::convert::Infallible` implementation which I found a bit weird...
    * Some naming nits with params.
        * I found `InferCtxt` + `InfCtx` and `Infcx` to be a lot of different ways to spell "inference context", so I got rid of the `InfCtx` type parameter name in favor of `Infcx` which is a more standard name.
        * I found `OptWithInfcx` to be a bit redundant -> `WithInfcx`.
    
    I'm making these changes because I intend to reuse the `InferCtxtLike` trait for uplifting the canonicalizer into a new trait -- conveniently, the information I need for uplifting the canonicalizer also is just the universe information of a type var, so it's super convenient 😸
    
    r? `@BoxyUwU` or `@lcnr`
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    cb65130 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#117092 - matthewjasper:attribute-validation…

    …, r=compiler-errors
    
    Add regression test for rust-lang#117058
    
    The new behavior in nightly is correct, so add a test that it stays this way.
    
    Closes rust-lang#117058
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    af58cda View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#117093 - rustbot:docs-update, r=ehuss

    Update books
    
    ## rust-lang/book
    
    1 commits in 72187f5cd0beaaa9c6f584156bcd88f921871e83..3dca2fc50b922a8efb94903b9fee8bb42ab48f38
    2023-10-19 18:01:47 UTC to 2023-10-19 18:01:47 UTC
    
    - Fix cargo doc links (rust-lang/book#3751)
    
    ## rust-embedded/book
    
    1 commits in eac173690b8cc99094e1d88bd49dd61127fbd285..22bca3d0f6e9b9b556689b54ce96f25b46ecd1b3
    2023-10-16 22:47:38 UTC to 2023-10-16 22:47:38 UTC
    
    - Improved hardware.md chapter. (rust-embedded/book#361)
    
    ## rust-lang/nomicon
    
    1 commits in ddfa4214487686e91b21aa29afb972c08a8f0d5b..1842257814919fa62e81bdecd5e8f95be2839dbb
    2023-10-17 15:11:58 UTC to 2023-10-17 15:11:58 UTC
    
    - Fixed `Hole::get` marked as unsafe in `exception-safety.md` (rust-lang/nomicon#427)
    
    ## rust-lang/reference
    
    2 commits in 142b2ed77d33f37a9973772bd95e6144ed9dce43..16fd3c06d9e558dae2d52000818274ae70c9e90a
    2023-10-14 22:31:04 UTC to 2023-10-11 15:35:55 UTC
    
    - Adjust reference for return-position `impl Trait` in trait and `async fn` in trait (rust-lang/reference#1409)
    - Fix temporary drop scope for last expression. (rust-lang/reference#1416)
    
    ## rust-lang/rust-by-example
    
    1 commits in 8eb3a01ab74c567b7174784892fb807f2c632d6b..6709beeb7d0fbc5ffc91ac4893a24434123b9bfa
    2023-10-20 19:11:21 UTC to 2023-10-20 19:11:21 UTC
    
    - docs: fix a typo (rust-lang/rust-by-example#1752)
    
    ## rust-lang/rustc-dev-guide
    
    5 commits in b98af7d661e4744baab81fb8dc7a049e44a4a998..b0ee9ec8fa59a6c7620165e061f4747202377a62
    2023-10-22 03:18:44 UTC to 2023-10-11 06:30:26 UTC
    
    - Add WF to glossary (rust-lang/rustc-dev-guide#1810)
    - recommend `unpretty=hir` alongside `unpretty=hir-tree` (rust-lang/rustc-dev-guide#1804)
    - Start a chapter about the evolving const effect system (rust-lang/rustc-dev-guide#1808)
    - Document subtle implied bounds issue in RPITIT inference (rust-lang/rustc-dev-guide#1807)
    - [suggested.md]  `changelog-seen` -> `change-id` in `shell.nix` (rust-lang/rustc-dev-guide#1806)
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5a0e51e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#117105 - onur-ozkan:remove-change-id-assert…

    …ion, r=albertlarsan68
    
    remove change-id assertion in bootstrap test
    
    In the bootstrap test, the assertion of the change-id fails whenever we update the change-id next to a breaking change in build configurations. This commit removes the assertion, as it's not critical or useful to have.
    
    ref rust-lang#115898 (comment)
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9510e97 View commit details
    Browse the repository at this point in the history