Add #[inline] to some recalcitrant ops::range methods #117038

saethlin · 2023-10-22T04:30:24Z

rustbot · 2023-10-22T04:30:31Z

(rustbot has picked a reviewer for you, use r? to override)

scottmcm · 2023-10-22T04:53:47Z

library/core/src/ops/range.rs

@@ -294,6 +297,7 @@ impl<Idx: PartialOrd<Idx>> RangeTo<Idx> {
    /// assert!(!(..1.0).contains(&f32::NAN));
    /// assert!(!(..f32::NAN).contains(&0.5));
    /// ```
+    #[inline]
    #[stable(feature = "range_contains", since = "1.35.0")]
    pub fn contains<U>(&self, item: &U) -> bool


Pondering: is it worth even implementing these via UFCS? This body could just be item < &self.end...

saethlin · 2023-10-22T21:18:14Z

Nothing else in queue so why not
@bors try @rust-timer queue

bors · 2023-10-22T21:19:23Z

⌛ Trying commit 2820568 with merge 2863645...

Add #[inline] to some recalcitrant ops::range methods Fixes rust-lang#116861

bors · 2023-10-22T22:42:32Z

☀️ Try build successful - checks-actions
Build commit: 2863645 (2863645ee76ee6ad192bfa54351cd4dd9c67aeb2)

rust-timer · 2023-10-23T00:24:41Z

Finished benchmarking commit (2863645): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.1%	[-4.1%, -4.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.1%	[-4.1%, -4.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	2

Bootstrap: 629.056s -> 630.522s (0.23%)
Artifact size: 304.13 MiB -> 304.11 MiB (-0.01%)

workingjubilee · 2023-10-28T08:40:52Z

@bors r+

bors · 2023-10-28T08:40:53Z

📌 Commit 2820568 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-10-28T13:21:03Z

⌛ Testing commit 2820568 with merge 7314873...

bors · 2023-10-28T15:15:21Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 7314873 to master...

rust-timer · 2023-10-28T16:36:59Z

Finished benchmarking commit (7314873): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 637.216s -> 636.535s (-0.11%)
Artifact size: 304.42 MiB -> 304.40 MiB (-0.01%)

Add #[inline] to some recalcitrant ops::range methods

2820568

rustbot assigned joshtriplett Oct 22, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 22, 2023

scottmcm reviewed Oct 22, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 22, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2023

Auto merge of rust-lang#117038 - saethlin:inline-range-methods, r=<try>

2863645

Add #[inline] to some recalcitrant ops::range methods Fixes rust-lang#116861

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 23, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2023

workingjubilee assigned workingjubilee and unassigned joshtriplett Oct 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2023

bors merged commit 7314873 into rust-lang:master Oct 28, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 28, 2023

saethlin deleted the inline-range-methods branch October 28, 2023 17:00

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add #[inline] to some recalcitrant ops::range methods #117038

Add #[inline] to some recalcitrant ops::range methods #117038

saethlin commented Oct 22, 2023

rustbot commented Oct 22, 2023

scottmcm Oct 22, 2023

saethlin commented Oct 22, 2023

This comment has been minimized.

bors commented Oct 22, 2023

bors commented Oct 22, 2023

This comment has been minimized.

rust-timer commented Oct 23, 2023

workingjubilee commented Oct 28, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

Add #[inline] to some recalcitrant ops::range methods #117038

Add #[inline] to some recalcitrant ops::range methods #117038

Conversation

saethlin commented Oct 22, 2023

rustbot commented Oct 22, 2023

Choose a reason for hiding this comment

saethlin commented Oct 22, 2023

This comment has been minimized.

bors commented Oct 22, 2023

bors commented Oct 22, 2023

This comment has been minimized.

rust-timer commented Oct 23, 2023

Overall result: no relevant changes - no action needed

workingjubilee commented Oct 28, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

Overall result: ❌ regressions - no action needed