documenation -> documentation

The word "active" is currently used in two different and confusing ways:
- `ACTIVE_FEATURES` actually means "available unstable features"
- `Features::active_features` actually means "features declared in the
  crate's code", which can include feature within `ACTIVE_FEATURES` but
  also others.

(This is also distinct from "enabled" features which includes declared
features but also some edition-specific features automatically enabled
depending on the edition in use.)

This commit changes the `Features::active_features` to
`Features::declared_features` which actually matches its meaning.
Likewise, `Features::active` becomes `Features::declared`.

…nt in async function for the `needless_pass_by_ref_mut` lint

Fix ice in `redundant_locals`

Fixes rust-lang#11619

Rebinding over macro like the code below, idents will be different (`x#4` and `x#0` in that case).

```rust
fn reassign_in_macro() {
  let x = 10;
  macro_rules! mac {
    ($i:ident) => {
      let mut x = x;
    }
  }
  mac!(y);
}
```

It causes unwrapping `None`.

https://github.com/rust-lang/rust-clippy/blob/9554e477c29e6ddca9e5cdce71524341ef9d48e8/clippy_lints/src/redundant_locals.rs#L88-L98

changelog: ICE: [`redundant_locals`]: No longer lints rebinding over macro

Fix typo in attrs.rs

documenation -> documentation

[`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods

Fixes rust-lang#11635

changelog: [`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods

Clean up `rustc_features`

Plenty more to be done, but this is a decent start.

r? `@Nilstrieb`

Fix two typos in lint description

Fix rust-lang#11636

changelog: none

…assocfn, r=dswij

`impl_trait_in_params` now supports impls and traits

Before this PR, the lint `impl_trait_in_params`. This PR gives the lint support for functions in impls and traits. (Also, some pretty heavy refactor)

fixes rust-lang#11548
changelog:[`impl_trait_in_params`] now supports `impl` blocks and functions in traits

Update ui_test to 0.21.2

Hopefully fixes rust-lang#11489

r? `@flip1995`

changelog: none

There are several that are unused and can be removed.

And there are some calls to `to_string`, which can be expressed more
nicely as a `foo_to_string` call, and then `to_string` need not be
`pub`. (This requires adding `pat_to_string`).

…e1-dead

`rustc_hir_pretty` cleanups

Just some improvements I found while looking through this code.

r? ``@fee1-dead``

[`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt`

changelog: [`manual_is_ascii_check`]: Also check for `is_ascii_hexdigt`

Fix/11134

Fix rust-lang#11134

Hir of `qpath` will be `TypeRelative(Ty { kind: Path(LangItem...` when a closure contains macro (e.g. rust-lang/rust-clippy#11651) and rust-lang#11134, it causes panic.
This PR avoids panicking and emitting incomplete path string when `qpath` contains `LangItem`.

changelog: none

The await desugaring contains two calls (`Poll::new_unchecked` and
`get_context`) inside a single unsafe block. That violates the lint.

…as return type

…fate

[`get_first`]: lint on non-primitive slices

Fixes rust-lang#11594

I left the issue open for a couple days before making the PR to see if anyone has something to say, but it looks like there aren't any objections to removing this check that prevented linting on non-primitive slices, so here's the PR now.
There's a couple of instances in clippy itself where we now emit the lint. The actual relevant change is in the first commit and fixing the `.get(0)` instances in clippy itself is in the 2nd commit.

changelog: [`get_first`]: lint on non-primitive slices

…les, r=flip1995

triagebot no-merges: exclude "Rustup"s, add labels

rust-lang/triagebot#1720

changelog: none

Document conflicting lints

Documents the outcome described in rust-lang/rust-clippy#11662 so that the situation can be avoided in the future by other individuals.

changelog: none

…st` respect the `ignore-interior-mutability` configuration entry

changelog: Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>

[`unnecessary_lazy_eval`]: reduce applicability if closure has return type annotation

Fixes rust-lang#11672

We already check if closure parameters don't have type annotations and reduce the applicability to `MaybeIncorrect` if they do, since those help type inference and removing them breaks code. We didn't do this for return type annotations however. This PR adds it. This doesn't change it to produce a fix that will compile, but it will prevent rustfix from auto-applying it.

(In general I'm not sure if we can suggest a fix that will compile. In this specific example, it might be possible to suggest `&[] as &[u8]`, but as-casts won't always work, e.g. `Default::default() as &[u8]` is a compile error, so just reducing applicability should be a safe fix in any case for now)

changelog: [`unnecessary_lazy_eval`]: reduce applicability to `MaybeIncorrect` if closure has return type annotation

…th-the-lints!!, r=giraffate

Make `multiple_unsafe_ops_per_block` ignore await desugaring

The await desugaring contains two calls (`Poll::new_unchecked` and `get_context`) inside a single unsafe block. That violates the lint.

fixes rust-lang#11312

changelog: [`multiple_unsafe_ops_per_block`]: fix false positives in `.await`

…ut-regression-test-11610, r=blyxyas

Add regression test for rust-lang#11610 about mutable usage of argument in async function for the `needless_pass_by_ref_mut` lint

Fixes rust-lang/rust-clippy#11610.

This was already fixed. I simply added a regression test.

changelog: Add regression test for rust-lang#11610 about mutable usage of argument in async function for the `needless_pass_by_ref_mut` lint

…nsafe block or function

…t emitted if variable is used in an unsafe block or function

side effect for `enum_variants`:
use .first() instead of .get(0) in enum_variants lint
move to_camel_case to str_util module
move module, enum and struct name repetitions check to a single file `item_name_repetitions`
rename enum_variants threshold config option

…ut-unsafe-fn-block, r=blyxyas

Don't emit `needless_pass_by_ref_mut` if the variable is used in an unsafe block or function

Fixes rust-lang/rust-clippy#11586.
Fixes rust-lang/rust-clippy#11180.

As suggested in the two issues above, this lint should not be emitted if this an unsafe function or if the argument is used in an unsafe block.

changelog: [`needless_pass_by_ref_mut`]: Don't emit if the variable is used in an unsafe block or function

add lint for struct field names

changelog: [`struct_field_names`]: lint structs with the same pre/postfix in all fields or with fields that are pre/postfixed with the name of the struct.

fixes rust-lang#2555

I've followed general structure and naming from the code in [enum_variants](https://github.com/rust-lang/rust-clippy/blob/b788addfcc955368b9771b77d312c248fab60253/clippy_lints/src/enum_variants.rs) lint, which implements the same logic for enum variants.

…ass_by_ref_mut` lint

…mut` lint

Fix rust-lang#78206.

…flip1995

Deserialize `Msrv` directly in `Conf`

Gives the error a span pointing to the invalid config value

Also puts `Conf` itself in the `OnceLock` rather than just the `Msrv` for [the `register_late_mod_pass` work](rust-lang#116731) since it will be used from two different callbacks

changelog: none

…ut-closure-non-async-fn, r=blyxyas

Needless pass by ref mut closure non async fn

Fixes rust-lang/rust-clippy#11620.
Fixes rust-lang/rust-clippy#11561.

changelog: [`needless_pass_by_ref_mut`]: Correctly handle arguments moved into closure in non-async functions.

r? `@Centri3`

…r-errors

Implement rustc part of RFC 3127 trim-paths

This PR implements (or at least tries to) [RFC 3127 trim-paths](rust-lang#111540), the rustc part. That is `-Zremap-path-scope` with all of it's components/scopes.

`@rustbot` label: +F-trim-paths

[`map_identity`]: allow closure with type annotations

Fixes rust-lang#9122

`.map(|a: u32| a)` can help type inference, so we should probably allow this and not warn about "unnecessary map of the identity function"

changelog: [`map_identity`]: allow closure with type annotations

Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry

Fix rust-lang#10537

changelog: Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry

…ntri3

Warn missing_enforced_import_renames by default

Similar to rust-lang/rust-clippy#8261 that did the same thing to disallowed_methods & disallowed_types.
This lint is also only triggered if import renames are defined in the `clippy.toml` file.

changelog: Moved [`missing_enforced_import_renames`] to `style` (Now warn-by-default)
[rust-lang#11539](rust-lang/rust-clippy#11539)

Rustup

r? `@ghost`

changelog: none