Tweak suggestion span for outer attr and point at item following invalid inner attr #116868

estebank · 2023-10-18T00:24:49Z

After:

error: `unix_sigpipe` attribute cannot be used at crate level
  --> $DIR/unix_sigpipe-crate.rs:2:1
   |
LL | #![unix_sigpipe = "inherit"]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
LL |
LL | fn main() {}
   | ------------ the inner attribute doesn't annotate this function
   |
help: perhaps you meant to use an outer attribute
   |
LL - #![unix_sigpipe = "inherit"]
LL + #[unix_sigpipe = "inherit"]
   |

Before:

error: `unix_sigpipe` attribute cannot be used at crate level
  --> $DIR/unix_sigpipe-crate.rs:2:1
   |
LL | #![unix_sigpipe = "inherit"]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: perhaps you meant to use an outer attribute
   |
LL | #[unix_sigpipe = "inherit"]
   | ~~~~~~~~~~~~~~~~~~~~~~~~~~~

CC #89566.

rustbot · 2023-10-18T00:24:57Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_passes/src/check_attr.rs

compiler/rustc_passes/src/errors.rs

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs-error.stderr

petrochenkov · 2023-10-26T17:42:11Z

r=me after squashing commits
@rustbot author

CC rust-lang#89566.

estebank · 2023-10-26T21:01:38Z

@bors r=petrochenkov

bors · 2023-10-26T21:01:40Z

📌 Commit 27919ce has been approved by petrochenkov

It is now in the queue for this repository.

Tweak suggestion span for outer attr and point at item following invalid inner attr After: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LL | LL | fn main() {} | ------------ the inner attribute doesn't annotate this function | help: perhaps you meant to use an outer attribute | LL - #![unix_sigpipe = "inherit"] LL + #[unix_sigpipe = "inherit"] | ``` Before: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: perhaps you meant to use an outer attribute | LL | #[unix_sigpipe = "inherit"] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` CC rust-lang#89566.

Rollup of 5 pull requests Successful merges: - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation) - rust-lang#117170 (Add support for i586-unknown-netbsd as target.) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) r? `@ghost` `@rustbot` modify labels: rollup

Tweak suggestion span for outer attr and point at item following invalid inner attr After: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LL | LL | fn main() {} | ------------ the inner attribute doesn't annotate this function | help: perhaps you meant to use an outer attribute | LL - #![unix_sigpipe = "inherit"] LL + #[unix_sigpipe = "inherit"] | ``` Before: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: perhaps you meant to use an outer attribute | LL | #[unix_sigpipe = "inherit"] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` CC rust-lang#89566.

Rollup of 5 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) - rust-lang#117241 (Stash and cancel cycle errors for auto trait leakage in opaques) - rust-lang#117262 (Create a new ConstantKind variant (ZeroSized) for StableMIR) - rust-lang#117266 (replace transmute by raw pointer cast) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116868 - estebank:suggestion, r=petrochenkov Tweak suggestion span for outer attr and point at item following invalid inner attr After: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ LL | LL | fn main() {} | ------------ the inner attribute doesn't annotate this function | help: perhaps you meant to use an outer attribute | LL - #![unix_sigpipe = "inherit"] LL + #[unix_sigpipe = "inherit"] | ``` Before: ``` error: `unix_sigpipe` attribute cannot be used at crate level --> $DIR/unix_sigpipe-crate.rs:2:1 | LL | #![unix_sigpipe = "inherit"] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: perhaps you meant to use an outer attribute | LL | #[unix_sigpipe = "inherit"] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` CC rust-lang#89566.

rustbot assigned petrochenkov Oct 18, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2023

estebank changed the title ~~Tweak suggestion span~~ Tweak suggestion span for outer attr and point at item following invalid inner attr Oct 18, 2023

petrochenkov reviewed Oct 25, 2023

View reviewed changes

compiler/rustc_passes/src/check_attr.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/errors.rs Outdated Show resolved Hide resolved

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs-error.stderr Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

Tweak suggestion spans for invalid crate-level inner attribute

27919ce

CC rust-lang#89566.

estebank force-pushed the suggestion branch from 87b88a1 to 27919ce Compare October 26, 2023 18:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2023

TaKO8Ki mentioned this pull request Oct 27, 2023

Rollup of 5 pull requests #117255

Closed

TaKO8Ki mentioned this pull request Oct 27, 2023

Rollup of 5 pull requests #117264

Closed

matthiaskrgr mentioned this pull request Oct 27, 2023

Rollup of 6 pull requests #117272

Merged

bors merged commit a69fb48 into rust-lang:master Oct 27, 2023

rustbot added this to the 1.75.0 milestone Oct 27, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the suggestion branch November 9, 2023 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tweak suggestion span for outer attr and point at item following invalid inner attr #116868

Tweak suggestion span for outer attr and point at item following invalid inner attr #116868

Uh oh!

estebank commented Oct 18, 2023 •

edited

Loading

Uh oh!

rustbot commented Oct 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Oct 26, 2023

Uh oh!

estebank commented Oct 26, 2023

Uh oh!

bors commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tweak suggestion span for outer attr and point at item following invalid inner attr #116868

Tweak suggestion span for outer attr and point at item following invalid inner attr #116868

Uh oh!

Conversation

estebank commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Oct 26, 2023

Uh oh!

estebank commented Oct 26, 2023

Uh oh!

bors commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

estebank commented Oct 18, 2023 •

edited

Loading