Make `rustc_onunimplemented` export path agnostic #116805

Noratrieb · 2023-10-16T17:39:05Z

This makes it so that all the matchers that match against paths use the definition path instead of the export path. This removes all duplication around std/alloc/core.

This is not necessarily optimal because we now depend on internal implementation details like core::ops::control_flow::ControlFlow, which is not very nice and probably not acceptable for a stable on_unimplemented.

An alternative would be to just string-replace normalize away alloc/core to std as a special case, keeping the export paths but making it so that we're still fully standard library flavor agnostic.

Looking at the diff, I'm starting to think that some simple string replacement would go a long way towards fixing the problem of duplication while keeping export paths...

What do you prefer?

Also @weiznich for your thoughts about the stable version.

r? compiler-errors

This makes it so that all the matchers that match against paths use the definition path instead of the export path. This removes all duplication around `std`/`alloc`/`core`. This is not necessarily optimal because we now depend on internal implementation details like `core::ops::control_flow::ControlFlow`, which is not very nice and probably not acceptable for a stable `on_unimplemented`. An alternative would be to just string-replace normalize away `alloc`/`core` to `std` as a special case, keeping the export paths but making it so that we're still fully standard library flavor agnostic.

compiler-errors · 2023-10-16T17:50:13Z

I think this makes sense, and I also think that at least for libstd/liballoc/libcore, using the definition path is the best to make sure we actually always match against the item we're looking for.

Since on_unimplemented actually lets you define multiple string matches per symbol, you could export both the visible path and the definition path for the purposes of the user-facing on_unimplemented?

compiler-errors · 2023-10-16T17:50:18Z

r=me

compiler-errors · 2023-10-16T19:01:22Z

@bors r+

bors · 2023-10-16T19:01:24Z

📌 Commit 414135d has been approved by compiler-errors

It is now in the queue for this repository.

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#116754 (coverage: Several small cleanups in `spans`) - rust-lang#116798 (Improve display of parallel jobs in rustdoc-gui tester script) - rust-lang#116800 (Fix implied outlives check for GAT in RPITIT) - rust-lang#116805 (Make `rustc_onunimplemented` export path agnostic) - rust-lang#116808 (Add myself to smir triage) - rust-lang#116811 (Preserve unicode escapes in format string literals when pretty-printing AST) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116805 - Nilstrieb:onunimplemented-std-core-alloc-whatever-who-cares, r=compiler-errors Make `rustc_onunimplemented` export path agnostic This makes it so that all the matchers that match against paths use the definition path instead of the export path. This removes all duplication around `std`/`alloc`/`core`. This is not necessarily optimal because we now depend on internal implementation details like `core::ops::control_flow::ControlFlow`, which is not very nice and probably not acceptable for a stable `on_unimplemented`. An alternative would be to just string-replace normalize away `alloc`/`core` to `std` as a special case, keeping the export paths but making it so that we're still fully standard library flavor agnostic. Looking at the diff, I'm starting to think that some simple string replacement would go a long way towards fixing the problem of duplication while keeping export paths... What do you prefer? Also `@weiznich` for your thoughts about the stable version. r? compiler-errors

weiznich · 2023-10-17T09:35:52Z

Thanks for pining me. I don't think this should affect a potential stable version of on_unimplemented. The RFC proposes a different syntax for that, based on using actual name resolution. In addition I personally would like to try to stabilize a minimal version first, which would not allow filters at all. So just message, label and note.

rustbot assigned compiler-errors Oct 16, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2023

GuillaumeGomez mentioned this pull request Oct 16, 2023

Rollup of 6 pull requests #116820

Merged

bors merged commit 347f7f3 into rust-lang:master Oct 17, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 17, 2023

Noratrieb deleted the onunimplemented-std-core-alloc-whatever-who-cares branch October 17, 2023 07:00

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `rustc_onunimplemented` export path agnostic #116805

Make `rustc_onunimplemented` export path agnostic #116805

Noratrieb commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

bors commented Oct 16, 2023

weiznich commented Oct 17, 2023

Make rustc_onunimplemented export path agnostic #116805

Make rustc_onunimplemented export path agnostic #116805

Conversation

Noratrieb commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

bors commented Oct 16, 2023

weiznich commented Oct 17, 2023

Make `rustc_onunimplemented` export path agnostic #116805

Make `rustc_onunimplemented` export path agnostic #116805