Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unsafe getuid with nix impl of Uid #116476

Closed
wants to merge 1 commit into from
Closed

Replace unsafe getuid with nix impl of Uid #116476

wants to merge 1 commit into from

Conversation

apekros
Copy link
Contributor

@apekros apekros commented Oct 6, 2023

Continues #109859

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 6, 2023
@onur-ozkan onur-ozkan mentioned this pull request Oct 9, 2023
Merged
@apekros apekros closed this Oct 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#116577 - onur-ozkan:add-safety-block-on-uns…
7f6ff13 
…afe, r=clubby789

add `SAFETY` block on the usage of unsafe `getuid`

We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#116577 - onur-ozkan:add-safety-block-on-uns…
b236d11 
…afe, r=clubby789

add `SAFETY` block on the usage of unsafe `getuid`

We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2023
@rust-timer
Unrolled build for rust-lang#116577
7bf83fc 
Rollup merge of rust-lang#116577 - onur-ozkan:add-safety-block-on-unsafe, r=clubby789

add `SAFETY` block on the usage of unsafe `getuid`

We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jul 27, 2024
Open
8 tasks
@Kobzol Kobzol mentioned this pull request Jul 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan left review comments

Assignees

@clubby789 clubby789

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apekros @rustbot @onur-ozkan @clubby789