rustdoc: use JS to inline target type impl docs into alias #116471

notriddle · 2023-10-06T04:10:57Z

Preview docs:

This pull request also includes a bug fix for trait alias inlining across crates. This means more documentation is generated, and is why ripgrep runs slower (it's a thin wrapper on top of the grep crate, so 5% of its docs are now the Result type).

Before, built with rustdoc 1.75.0-nightly (aa1a71e 2023-10-26), Result type alias method docs are missing: http://notriddle.com/rustdoc-html-demo-5/ripgrep-js-nightly/rg/type.Result.html
After, built with this branch, all the methods on Result are shown: http://notriddle.com/rustdoc-html-demo-5/ripgrep-js-trait-alias/rg/type.Result.html

Review note: This is mostly just reverting #115201. The last commit has the new work in it.

Fixes #115718

This is an attempt to balance three problems, each of which would
be violated by a simpler implementation:

A type alias should show all the impl blocks for the target
type, and vice versa, if they're applicable. If nothing was
done, and rustdoc continues to match them up in HIR, this
would not work.
Copying the target type's docs into its aliases' HTML pages
directly causes far too much redundant HTML text to be generated
when a crate has large numbers of methods and large numbers
of type aliases.
Using JavaScript exclusively for type alias impl docs would
be a functional regression, and could make some docs very hard
to find for non-JS readers.
Making sure that only applicable docs are show in the
resulting page requires a type checkers. Do not reimplement
the type checker in JavaScript.

So, to make it work, rustdoc stashes these type-alias-inlined docs
in a JSONP "database-lite". The file is generated in write_shared.rs,
included in a <script> tag added in print_item.rs, and main.js
takes care of patching the additional docs into the DOM.

The format of trait.impl and type.impl JS files are superficially
similar. Each line, except the JSONP wrapper itself, belongs to a crate,
and they are otherwise separate (rustdoc should be idempotent). The
"meat" of the file is HTML strings, so the frontend code is very simple.
Links are relative to the doc root, though, so the frontend needs to fix
that up, and inlined docs can reuse these files.

However, there are a few differences, caused by the sophisticated
features that type aliases have. Consider this crate graph:

 ---------------------------------
 | crate A: struct Foo<T>        |
 |          type Bar = Foo<i32>  |
 |          impl X for Foo<i8>   |
 |          impl Y for Foo<i32>  |
 ---------------------------------
     |
 ----------------------------------
 | crate B: type Baz = A::Foo<i8> |
 |          type Xyy = A::Foo<i8> |
 |          impl Z for Xyy        |
 ----------------------------------

The type.impl/A/struct.Foo.js JS file has a structure kinda like this:

JSONP({
"A": [["impl Y for Foo<i32>", "Y", "A::Bar"]],
"B": [["impl X for Foo<i8>", "X", "B::Baz", "B::Xyy"], ["impl Z for Xyy", "Z", "B::Baz"]],
});

When the type.impl file is loaded, only the current crate's docs are
actually used. The main reason to bundle them together is that there's
enough duplication in them for DEFLATE to remove the redundancy.

The contents of a crate are a list of impl blocks, themselves
represented as lists. The first item in the sublist is the HTML block,
the second item is the name of the trait (which goes in the sidebar),
and all others are the names of type aliases that successfully match.

This way:

There's no need to generate these files for types that have no aliases
in the current crate. If a dependent crate makes a type alias, it'll
take care of generating its own docs.
There's no need to reimplement parts of the type checker in
JavaScript. The Rust backend does the checking, and includes its
results in the file.
Docs defined directly on the type alias are dropped directly in the
HTML by render_assoc_items, and are accessible without JavaScript.
The JSONP file will not list impl items that are known to be part
of the main HTML file already.

rustbot · 2023-10-06T04:11:05Z

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-06T04:11:09Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

rustbot · 2023-10-06T06:32:34Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

Some changes occurred in GUI tests.

cc @GuillaumeGomez

src/librustdoc/html/templates/sidebar.html

src/librustdoc/html/static/js/main.js

GuillaumeGomez · 2023-10-06T18:35:41Z

src/librustdoc/html/static/js/main.js

@@ -587,6 +588,177 @@ function preLoadCss(cssUrl) {
        window.register_implementors(window.pending_implementors);
    }

+    // <https://github.com/search?q=repo%3Arust-lang%2Frust+[RUSTDOCIMPL]+type.impl&type=code>
+    window.register_type_impls = imp => {


Also, could you add some comments explaining a bit more what it is manipulating and what it's generating? Not sure what the best format would be here though. There are a lot of smaller "sections" in the code, so maybe have a comment for each section explaining what it's doing instead of a big one explaining everything at the start? What do you think?

Yeah, it definitely needs more doc comment.

GuillaumeGomez · 2023-10-06T18:37:31Z

This is a great PR. I didn't see any big issue from it. Considering how big it is, it's very likely I missed things so might be better to get a second reviewer as well. Also, once updated, can you start a perf check please? I expect a big improvement in doc size but I'm curious about the impact on the doc generation.

notriddle · 2023-10-07T15:11:15Z

@bors try @rust-timer queue

bors · 2023-10-07T15:12:25Z

⌛ Trying commit 760c7f0 with merge a68b523...

…r=<try> rustdoc: use JS to inline target type impl docs into alias Preview docs: - https://notriddle.com/rustdoc-html-demo-5/js-trait-alias/std/io/type.Result.html - https://notriddle.com/rustdoc-html-demo-5/js-trait-alias-compiler/rustc_middle/ty/type.PolyTraitRef.html *Review note: This is mostly just reverting rust-lang#115201. The last commit has the new work in it.* Fixes rust-lang#115718 This is an attempt to balance three problems, each of which would be violated by a simpler implementation: - A type alias should show all the `impl` blocks for the target type, and vice versa, if they're applicable. If nothing was done, and rustdoc continues to match them up in HIR, this would not work. - Copying the target type's docs into its aliases' HTML pages directly causes far too much redundant HTML text to be generated when a crate has large numbers of methods and large numbers of type aliases. - Using JavaScript exclusively for type alias impl docs would be a functional regression, and could make some docs very hard to find for non-JS readers. - Making sure that only applicable docs are show in the resulting page requires a type checkers. Do not reimplement the type checker in JavaScript. So, to make it work, rustdoc stashes these type-alias-inlined docs in a JSONP "database-lite". The file is generated in `write_shared.rs`, included in a `<script>` tag added in `print_item.rs`, and `main.js` takes care of patching the additional docs into the DOM. The format of `trait.impl` and `type.impl` JS files are superficially similar. Each line, except the JSONP wrapper itself, belongs to a crate, and they are otherwise separate (rustdoc should be idempotent). The "meat" of the file is HTML strings, so the frontend code is very simple. Links are relative to the doc root, though, so the frontend needs to fix that up, and inlined docs can reuse these files. However, there are a few differences, caused by the sophisticated features that type aliases have. Consider this crate graph: ```text --------------------------------- | crate A: struct Foo<T> | | type Bar = Foo<i32> | | impl X for Foo<i8> | | impl Y for Foo<i32> | --------------------------------- | ---------------------------------- | crate B: type Baz = A::Foo<i8> | | type Xyy = A::Foo<i8> | | impl Z for Xyy | ---------------------------------- ``` The type.impl/A/struct.Foo.js JS file has a structure kinda like this: ```js JSONP({ "A": [["impl Y for Foo<i32>", "Y", "A::Bar"]], "B": [["impl X for Foo<i8>", "X", "B::Baz", "B::Xyy"], ["impl Z for Xyy", "Z", "B::Baz"]], }); ``` When the type.impl file is loaded, only the current crate's docs are actually used. The main reason to bundle them together is that there's enough duplication in them for DEFLATE to remove the redundancy. The contents of a crate are a list of impl blocks, themselves represented as lists. The first item in the sublist is the HTML block, the second item is the name of the trait (which goes in the sidebar), and all others are the names of type aliases that successfully match. This way: - There's no need to generate these files for types that have no aliases in the current crate. If a dependent crate makes a type alias, it'll take care of generating its own docs. - There's no need to reimplement parts of the type checker in JavaScript. The Rust backend does the checking, and includes its results in the file. - Docs defined directly on the type alias are dropped directly in the HTML by `render_assoc_items`, and are accessible without JavaScript. The JSONP file will not list impl items that are known to be part of the main HTML file already. [JSONP]: https://en.wikipedia.org/wiki/JSONP

bors · 2023-10-07T16:25:19Z

☀️ Try build successful - checks-actions
Build commit: a68b523 (a68b52379d0536887ff555de1884b415cac2d0b1)

rust-timer · 2023-10-07T21:52:05Z

Finished benchmarking commit (a68b523): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.3%, 5.0%]	10
Regressions ❌ (secondary)	1.8%	[1.5%, 2.0%]	2
Improvements ✅ (primary)	-2.7%	[-3.3%, -1.6%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-3.3%, 5.0%]	13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.5%	[2.3%, 4.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.5%	[2.3%, 4.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.5%, 5.2%]	4
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-3.1%	[-3.3%, -2.9%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[-3.3%, 5.2%]	6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 624.544s -> 623.266s (-0.20%)
Artifact size: 270.60 MiB -> 270.70 MiB (0.04%)

notriddle · 2023-10-07T22:00:47Z

I'm going to need to figure out what happened to ripgrip. Other than that, HTML size seems to be mostly improved (I ran personal tests on the typenum and nalgebra crates; they're all-around improved).

Perf results for doc_bytes: https://perf.rust-lang.org/compare.html?start=48e24629e946339943b194163a81374cf533ce5a&end=a68b52379d0536887ff555de1884b415cac2d0b1&stat=size%3Adoc_bytes

Doc bytes for nalgebra and typenum:

$ du -s typenum/target/doc nalgebra/target/doc
105336	typenum/target/doc
86408	nalgebra/target/doc
$ du -hs typenum/target/doc nalgebra/target/doc
 51M	typenum/target/doc
 42M	nalgebra/target/doc

…r=<try> rustdoc: use JS to inline target type impl docs into alias Preview docs: - https://notriddle.com/rustdoc-html-demo-5/js-trait-alias/std/io/type.Result.html - https://notriddle.com/rustdoc-html-demo-5/js-trait-alias-compiler/rustc_middle/ty/type.PolyTraitRef.html *Review note: This is mostly just reverting rust-lang#115201. The last commit has the new work in it.* Fixes rust-lang#115718 This is an attempt to balance three problems, each of which would be violated by a simpler implementation: - A type alias should show all the `impl` blocks for the target type, and vice versa, if they're applicable. If nothing was done, and rustdoc continues to match them up in HIR, this would not work. - Copying the target type's docs into its aliases' HTML pages directly causes far too much redundant HTML text to be generated when a crate has large numbers of methods and large numbers of type aliases. - Using JavaScript exclusively for type alias impl docs would be a functional regression, and could make some docs very hard to find for non-JS readers. - Making sure that only applicable docs are show in the resulting page requires a type checkers. Do not reimplement the type checker in JavaScript. So, to make it work, rustdoc stashes these type-alias-inlined docs in a JSONP "database-lite". The file is generated in `write_shared.rs`, included in a `<script>` tag added in `print_item.rs`, and `main.js` takes care of patching the additional docs into the DOM. The format of `trait.impl` and `type.impl` JS files are superficially similar. Each line, except the JSONP wrapper itself, belongs to a crate, and they are otherwise separate (rustdoc should be idempotent). The "meat" of the file is HTML strings, so the frontend code is very simple. Links are relative to the doc root, though, so the frontend needs to fix that up, and inlined docs can reuse these files. However, there are a few differences, caused by the sophisticated features that type aliases have. Consider this crate graph: ```text --------------------------------- | crate A: struct Foo<T> | | type Bar = Foo<i32> | | impl X for Foo<i8> | | impl Y for Foo<i32> | --------------------------------- | ---------------------------------- | crate B: type Baz = A::Foo<i8> | | type Xyy = A::Foo<i8> | | impl Z for Xyy | ---------------------------------- ``` The type.impl/A/struct.Foo.js JS file has a structure kinda like this: ```js JSONP({ "A": [["impl Y for Foo<i32>", "Y", "A::Bar"]], "B": [["impl X for Foo<i8>", "X", "B::Baz", "B::Xyy"], ["impl Z for Xyy", "Z", "B::Baz"]], }); ``` When the type.impl file is loaded, only the current crate's docs are actually used. The main reason to bundle them together is that there's enough duplication in them for DEFLATE to remove the redundancy. The contents of a crate are a list of impl blocks, themselves represented as lists. The first item in the sublist is the HTML block, the second item is the name of the trait (which goes in the sidebar), and all others are the names of type aliases that successfully match. This way: - There's no need to generate these files for types that have no aliases in the current crate. If a dependent crate makes a type alias, it'll take care of generating its own docs. - There's no need to reimplement parts of the type checker in JavaScript. The Rust backend does the checking, and includes its results in the file. - Docs defined directly on the type alias are dropped directly in the HTML by `render_assoc_items`, and are accessible without JavaScript. The JSONP file will not list impl items that are known to be part of the main HTML file already. [JSONP]: https://en.wikipedia.org/wiki/JSONP

bors · 2023-10-23T10:12:04Z

☀️ Try build successful - checks-actions
Build commit: 9811b1e (9811b1e81b2480e97e524ff46932fc2d5c25fdaa)

rust-timer · 2023-10-23T11:23:53Z

Finished benchmarking commit (9811b1e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.3%, 5.0%]	10
Regressions ❌ (secondary)	1.8%	[1.5%, 2.1%]	2
Improvements ✅ (primary)	-2.8%	[-3.4%, -1.6%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-3.4%, 5.0%]	13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-3.9%, -2.0%]	4
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	-1.3%	[-3.9%, 3.7%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[1.9%, 4.6%]	4
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-2.7%	[-3.3%, -1.7%]	3
Improvements ✅ (secondary)	-4.0%	[-4.2%, -3.7%]	2
All ❌✅ (primary)	0.5%	[-3.3%, 4.6%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 304.28 MiB -> 304.31 MiB (0.01%)

notriddle · 2023-10-27T16:04:49Z

Why there's a perf regression

This pull request includes a bug fix for trait alias inlining across crates. This means more documentation is generated, and is why ripgrep runs slower (it's a thin wrapper on top of the grep crate, so 5% of its docs are now the Result type).

Before, built with rustdoc 1.75.0-nightly (aa1a71e 2023-10-26), Result type alias method docs are missing: http://notriddle.com/rustdoc-html-demo-5/ripgrep-js-nightly/rg/type.Result.html
After, built with this branch, all the methods on Result are shown: http://notriddle.com/rustdoc-html-demo-5/ripgrep-js-trait-alias/rg/type.Result.html

GuillaumeGomez · 2023-10-27T16:55:54Z

Do you have before/after numbers for the size of the generated docs for std, core and alloc by any chance?

notriddle · 2023-10-27T18:54:07Z

@GuillaumeGomez
It makes the standard library and the compiler docs both smaller.
It's not as stark as typenum and nalgebra, though:

[michael@deep-thought rust-build]$ du -hs after/doc before/doc
669M	after/doc
778M	before/doc
[michael@deep-thought rust-build]$ du -hs after/compiler-doc before/compiler-doc
710M	after/compiler-doc
722M	before/compiler-doc

GuillaumeGomez · 2023-10-27T18:55:02Z

That's still quite a lot, nice work!

@bors r+ rollup=never

bors · 2023-10-27T18:55:04Z

📌 Commit 46fdeb2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2023-10-27T23:08:28Z

⌛ Testing commit 46fdeb2 with merge 6f349cd...

bors · 2023-10-28T01:03:28Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 6f349cd to master...

rust-timer · 2023-10-28T05:43:35Z

Finished benchmarking commit (6f349cd): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.3%, 5.0%]	10
Regressions ❌ (secondary)	1.0%	[0.2%, 1.9%]	4
Improvements ✅ (primary)	-2.7%	[-3.4%, -1.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-3.4%, 5.0%]	13

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.9%, 4.9%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-3.3%, -2.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[-3.3%, 4.9%]	6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.719s -> 635.428s (-0.05%)
Artifact size: 304.53 MiB -> 304.56 MiB (0.01%)

nnethercote · 2023-10-29T21:19:29Z

The perf regression was explained above; it's very small, rustdoc-only, and is more than balanced by the large reductions in generated doc size.

@rustbot label: +perf-regression-triaged

rustdoc apparently cannot generate docs for methods implemented on a type alias target unless said type alias is exported from the crate. I think it's b/c under the hood rustdoc is using some clever javascript tricks to inline documentation. They do this to avoid HTML bloat for crates with lots of type alises [0]. The upshot of this is now trait impls like `AsFd` are visible in web docs. This is really important, as otherwise it's quite difficult for users to discover these APIs. The downside of this approach is we publically expose implementation structs in docs. It's not a huge deal, as with skeleton it should be fairly obvious what types they should actually interact with. I kinda doubt anyone reads the docs front to back. [0]: rust-lang/rust#116471

rustbot assigned jsha Oct 6, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 6, 2023

notriddle force-pushed the notriddle/js-trait-alias branch from 5b7b756 to 0243d95 Compare October 6, 2023 06:32

notriddle force-pushed the notriddle/js-trait-alias branch from 0243d95 to 8ab73e5 Compare October 6, 2023 06:47

This comment has been minimized.

Sign in to view

GuillaumeGomez reviewed Oct 6, 2023

View reviewed changes

src/librustdoc/html/templates/sidebar.html Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

GuillaumeGomez reviewed Oct 6, 2023

View reviewed changes

src/librustdoc/html/static/js/main.js Outdated Show resolved Hide resolved

GuillaumeGomez reviewed Oct 6, 2023

View reviewed changes

src/librustdoc/html/static/js/main.js Outdated Show resolved Hide resolved

GuillaumeGomez reviewed Oct 6, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/js-trait-alias branch from 319cb34 to 760c7f0 Compare October 7, 2023 15:10

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 7, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 7, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 23, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2023

bors merged commit 6f349cd into rust-lang:master Oct 28, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 28, 2023

bors mentioned this pull request Oct 28, 2023

rustdoc: Document lack of object safety on affected traits #113241

Merged

notriddle deleted the notriddle/js-trait-alias branch October 28, 2023 04:44

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

fmease mentioned this pull request Nov 9, 2023

fallible allocation experiment 2 #117738

Closed

gurry mentioned this pull request Feb 21, 2024

Broken parameter links in some of the stdlib documentation #121106

Closed

notriddle mentioned this pull request Jul 31, 2024

Mergeable rustdoc cross-crate info rust-lang/rfcs#3662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: use JS to inline target type impl docs into alias #116471

rustdoc: use JS to inline target type impl docs into alias #116471

notriddle commented Oct 6, 2023 •

edited

Loading

rustbot commented Oct 6, 2023

rustbot commented Oct 6, 2023

rustbot commented Oct 6, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

GuillaumeGomez Oct 6, 2023

notriddle Oct 6, 2023 •

edited

Loading

GuillaumeGomez commented Oct 6, 2023

This comment has been minimized.

notriddle commented Oct 7, 2023

This comment has been minimized.

bors commented Oct 7, 2023

bors commented Oct 7, 2023

This comment has been minimized.

rust-timer commented Oct 7, 2023

notriddle commented Oct 7, 2023

bors commented Oct 23, 2023

This comment has been minimized.

rust-timer commented Oct 23, 2023

notriddle commented Oct 27, 2023 •

edited

Loading

GuillaumeGomez commented Oct 27, 2023

notriddle commented Oct 27, 2023

GuillaumeGomez commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

nnethercote commented Oct 29, 2023

rustdoc: use JS to inline target type impl docs into alias #116471

rustdoc: use JS to inline target type impl docs into alias #116471

Conversation

notriddle commented Oct 6, 2023 • edited Loading

rustbot commented Oct 6, 2023

rustbot commented Oct 6, 2023

rustbot commented Oct 6, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

notriddle Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

GuillaumeGomez commented Oct 6, 2023

This comment has been minimized.

notriddle commented Oct 7, 2023

This comment has been minimized.

bors commented Oct 7, 2023

bors commented Oct 7, 2023

This comment has been minimized.

rust-timer commented Oct 7, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

notriddle commented Oct 7, 2023

bors commented Oct 23, 2023

This comment has been minimized.

rust-timer commented Oct 23, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

notriddle commented Oct 27, 2023 • edited Loading

Why there's a perf regression

GuillaumeGomez commented Oct 27, 2023

notriddle commented Oct 27, 2023

GuillaumeGomez commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 27, 2023

bors commented Oct 28, 2023

rust-timer commented Oct 28, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

nnethercote commented Oct 29, 2023

notriddle commented Oct 6, 2023 •

edited

Loading

notriddle Oct 6, 2023 •

edited

Loading

notriddle commented Oct 27, 2023 •

edited

Loading