Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• stabilize Option::as_(mut_)slice #116220 (stabilize Option::as_(mut_)slice)
• Add Span to various smir types #116288 (Add Span to various smir types)
• Move subtyper below reveal_all and change reveal_all #116415 (Move subtyper below reveal_all and change reveal_all)
• Add a note to duplicate diagnostics #116428 (Add a note to duplicate diagnostics)
• Do not assert that hidden types don't have erased regions. #116452 (Do not assert that hidden types don't have erased regions.)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 76d0b79 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 76d0b79 with merge cdca82c...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing cdca82c to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116220	stabilize Option::as_(mut_)slice	eccc52ac3e0b2169adc65d3d3f472d6d6d20344a (link)
#116288	Add Span to various smir types	b670d2c5205532fccc26321f57c39ed0dca6485b (link)
#116415	Move subtyper below reveal_all and change reveal_all	fa06accd86b54c0d468027915602915e16c6bde2 (link)
#116428	Add a note to duplicate diagnostics	5e5b8a0f3e991ff7a89cf977c348b3f8f05e74e5 (link)
#116452	Do not assert that hidden types don't have erased regions.	68a24eef89fe49901170e84232ce6630b0cc5417 (link)

previous master: 3bcad65fbf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (cdca82c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.9%, -0.5%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[1.3%, 7.4%]	5
Regressions ❌ (secondary)	3.1%	[1.4%, 4.8%]	2
Improvements ✅ (primary)	-5.3%	[-7.3%, -3.5%]	3
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	0.3%	[-7.3%, 7.4%]	8

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[3.9%, 5.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.4%]	12
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	6
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	12
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	6
All ❌✅ (primary)	0.0%	[-0.3%, 0.4%]	24

Bootstrap: 621.776s -> 622.141s (0.06%)
Artifact size: 271.95 MiB -> 271.92 MiB (-0.01%)