Stabilize `[const_]pointer_byte_offsets` #116205

WaffleLapkin · 2023-09-27T19:06:19Z

Closes #96283
Awaiting FCP completion: #96283 (comment)

r? libs-api

rustbot · 2023-09-28T17:25:42Z

The Miri subtree was changed

cc @rust-lang/miri

WaffleLapkin · 2023-09-28T17:27:43Z

tests/ui/consts/miri_unleashed/ptr_arith.rs

@@ -1,5 +1,5 @@
 // compile-flags: -Zunleash-the-miri-inside-of-you
-#![feature(core_intrinsics, pointer_byte_offsets)]
+#![feature(core_intrinsics)]


fyi: this test does not use either of those features :/

Ah, that's probably a silly copy-paste error then. Can you remove both feature flags while you are at it?

bors · 2023-10-04T02:43:00Z

☔ The latest upstream changes (presumably #116367) made this pull request unmergeable. Please resolve the merge conflicts.

WaffleLapkin · 2023-10-26T01:18:21Z

@rustbot review

dtolnay

Thank you!

dtolnay · 2023-10-27T05:28:02Z

@bors r+

bors · 2023-10-27T05:28:04Z

📌 Commit fe97fdf has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-10-27T07:47:45Z

⌛ Testing commit fe97fdf with merge 7b8b61f...

…offsets, r=dtolnay Stabilize `[const_]pointer_byte_offsets` Closes rust-lang#96283 Awaiting FCP completion: rust-lang#96283 (comment) r? libs-api

rust-log-analyzer · 2023-10-27T08:13:42Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] core::build_steps::compile::Rustc { target: x86_64-unknown-linux-gnu, compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, crates: [] } -- 0.000
##[group]Building tool miri (stage2 -> stage3, x86_64-unknown-linux-gnu)


command did not execute successfully: cd "/checkout" && env -u MAKEFLAGS -u MFLAGS AR_x86_64_unknown_linux_gnu="ar" CARGO_INCREMENTAL="0" CARGO_PROFILE_RELEASE_DEBUG="0" CARGO_PROFILE_RELEASE_DEBUG_ASSERTIONS="true" CARGO_PROFILE_RELEASE_OVERFLOW_CHECKS="true" CARGO_TARGET_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools" CC_x86_64_unknown_linux_gnu="sccache cc" CFG_COMPILER_HOST_TRIPLE="x86_64-unknown-linux-gnu" CFG_RELEASE="1.75.0-nightly" CFG_RELEASE_CHANNEL="nightly" CFG_RELEASE_NUM="1.75.0" CFG_VERSION="1.75.0-nightly (7b8b61f9d 2023-10-27)" CFG_VER_DATE="2023-10-27" CFG_VER_HASH="7b8b61f9d91c41010651710718e6cd35ea52fc58" CFLAGS_x86_64_unknown_linux_gnu="-ffunction-sections -fdata-sections -fPIC -m64" CXXFLAGS_x86_64_unknown_linux_gnu="-ffunction-sections -fdata-sections -fPIC -m64" CXX_x86_64_unknown_linux_gnu="sccache c++" DOC_RUST_LANG_ORG_CHANNEL="https://doc.rust-lang.org/nightly" LIBC_CHECK_CFG="1" LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/lib" LIBZ_SYS_STATIC="1" LZMA_API_STATIC="1" RANLIB_x86_64_unknown_linux_gnu="ar s" REAL_LIBRARY_PATH_VAR="LD_LIBRARY_PATH" RUSTBUILD_NATIVE_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/native" RUSTC="/checkout/obj/build/bootstrap/debug/rustc" RUSTC_BOOTSTRAP="1" RUSTC_BREAK_ON_ICE="1" RUSTC_ERROR_METADATA_DST="/checkout/obj/build/tmp/extended-error-metadata" RUSTC_HOST_FLAGS="-Zunstable-options --check-cfg=values(bootstrap)" RUSTC_INSTALL_BINDIR="bin" RUSTC_LIBDIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" RUSTC_LINT_FLAGS="-Wrust_2018_idioms -Wunused_lifetimes -Wsemicolon_in_expressions_from_macros -Dwarnings" RUSTC_PRINT_STEP_TIMINGS="1" RUSTC_REAL="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTC_SNAPSHOT="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTC_SNAPSHOT_LIBDIR="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" RUSTC_STAGE="2" RUSTC_SYSROOT="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" RUSTC_TLS_MODEL_INITIAL_EXEC="1" RUSTC_VERBOSE="0" RUSTDOC="/checkout/obj/build/bootstrap/debug/rustdoc" RUSTDOCFLAGS="--cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options --check-cfg=values(bootstrap) --check-cfg=values(parallel_compiler) --check-cfg=values(no_btreemap_remove_entry) --check-cfg=values(crossbeam_loom) --check-cfg=values(span_locations) --check-cfg=values(rustix_use_libc) --check-cfg=values(emulate_second_only_system) --check-cfg=values(windows_raw_dylib) -Dwarnings -Wrustdoc::invalid_codeblock_attributes --crate-version 1.75.0-nightly\t(7b8b61f9d\t2023-10-27)" RUSTDOC_REAL="/path/to/nowhere/rustdoc/not/required" RUSTFLAGS="--cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options --check-cfg=values(bootstrap) --check-cfg=values(parallel_compiler) --check-cfg=values(no_btreemap_remove_entry) --check-cfg=values(crossbeam_loom) --check-cfg=values(span_locations) --check-cfg=values(rustix_use_libc) --check-cfg=values(emulate_second_only_system) --check-cfg=values(windows_raw_dylib) -Zmacro-backtrace -Clink-args=-Wl,-z,origin -Clink-args=-Wl,-rpath,$ORIGIN/../lib -Csplit-debuginfo=off" RUST_TEST_THREADS="8" SYSROOT="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" TERM="xterm" __CARGO_DEFAULT_LIB_METADATA="nightlytool-rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "-Zcheck-cfg=names,values,output,features" "-Zbinary-dep-depinfo" "-j" "8" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/miri/Cargo.toml"
thread 'main' panicked at src/core/build_steps/test.rs:611:14:
in-tree tool
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:14

bors · 2023-10-27T08:16:18Z

💔 Test failed - checks-actions

dtolnay · 2023-10-27T08:22:16Z

@bors retry

bors · 2023-10-27T08:24:57Z

⌛ Testing commit fe97fdf with merge 54e57e6...

bors · 2023-10-27T10:18:27Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 54e57e6 to master...

rust-timer · 2023-10-27T11:40:13Z

Finished benchmarking commit (54e57e6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-3.5%, -0.8%]	2
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-2.1%	[-3.5%, -0.8%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	10.7%	[10.6%, 10.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.528s -> 634.843s (0.05%)
Artifact size: 304.48 MiB -> 304.48 MiB (-0.00%)

RalfJung · 2024-08-31T11:23:26Z

library/core/src/ptr/const_ptr.rs

-    #[rustc_const_unstable(feature = "const_pointer_byte_offsets", issue = "96283")]
+    #[stable(feature = "pointer_byte_offsets", since = "CURRENT_RUSTC_VERSION")]
+    #[rustc_const_stable(feature = "const_pointer_byte_offsets", since = "CURRENT_RUSTC_VERSION")]
+    #[rustc_allow_const_fn_unstable(set_ptr_value)]


Doesn't seem like @rust-lang/wg-const-eval got pinged for this? This exposes a const-intrinsic on stable, the WG should always be involved when that happens.

I can't find any mentions of the WG either, so this looks like an overlook on my part 💀

We should probably have automation for this kind of thing (i.e. ping the WG if the attributes are getting changed).

Yeah that would be nice, but seems hard -- I don't think we have any such automation for any case, currently.

Yes, rustbot currently only supports pings based on file names, not diff contents. Although I feel like it shouldn't be too hard to add this functionality 🤔

WaffleLapkin added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Sep 27, 2023

rustbot assigned BurntSushi Sep 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 27, 2023

WaffleLapkin removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 27, 2023

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the stabilize_pointer_byte_offsets branch from b812c12 to d70afd5 Compare September 27, 2023 23:09

This comment has been minimized.

Sign in to view

dtolnay assigned dtolnay and unassigned BurntSushi Sep 28, 2023

rust-cloud-vms bot force-pushed the stabilize_pointer_byte_offsets branch from d70afd5 to c151a17 Compare September 28, 2023 17:25

WaffleLapkin commented Sep 28, 2023

View reviewed changes

dtolnay approved these changes Sep 28, 2023

View reviewed changes

dtolnay removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2023

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2023

dtolnay removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Oct 6, 2023

rust-cloud-vms bot force-pushed the stabilize_pointer_byte_offsets branch from c151a17 to 3b2fe3f Compare October 25, 2023 20:12

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the stabilize_pointer_byte_offsets branch from 3b2fe3f to 7a05c02 Compare October 25, 2023 20:53

This comment has been minimized.

Sign in to view

Stabilize [const_]pointer_byte_offsets

e362241

rust-cloud-vms bot force-pushed the stabilize_pointer_byte_offsets branch from 7a05c02 to e362241 Compare October 25, 2023 22:35

Remove unused feature from a miri test

fe97fdf

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2023

dtolnay approved these changes Oct 27, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2023

bors merged commit 54e57e6 into rust-lang:master Oct 27, 2023

rustbot added this to the 1.75.0 milestone Oct 27, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

WaffleLapkin deleted the stabilize_pointer_byte_offsets branch November 7, 2023 20:46

WaffleLapkin mentioned this pull request Nov 7, 2023

Tracking Issue for pointer_bytes_offsets #96283

Closed

4 tasks

RalfJung reviewed Aug 31, 2024

View reviewed changes

Stabilize [const_]pointer_byte_offsets #116205

Stabilize [const_]pointer_byte_offsets #116205

Uh oh!

Conversation

WaffleLapkin commented Sep 27, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 28, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Oct 4, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

WaffleLapkin commented Oct 26, 2023

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

rust-log-analyzer commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

dtolnay commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

bors commented Oct 27, 2023

Uh oh!

rust-timer commented Oct 27, 2023

Overall result: no relevant changes - no action needed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Stabilize `[const_]pointer_byte_offsets` #116205

Stabilize `[const_]pointer_byte_offsets` #116205