-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Clarify example in Pin::new_unchecked docs
#116074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
@rustbot label A-docs |
This comment has been minimized.
This comment has been minimized.
|
Happy to approve with commits squashed. |
f2c4281 to
0f248d8
Compare
|
@Mark-Simulacrum I squashed them. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8c04c06): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.647s -> 630.411s (-0.20%) |
This example in the docs of
Pin::new_uncheckedpuzzled me for a relatively long time. Now I understand that it comes down to the difference between dropping thePinvs dropping the pinned value.I have extended the explanation to highlight this difference. In my opinion it is clearer now, and I hope it helps others understand
Pinbetter.