-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $message_type
field to distinguish json diagnostic outputs
#115691
Merged
Commits on Sep 19, 2023
-
Add
type
field to json diagnostic outputsCurrently the json-formatted outputs have no way to unambiguously determine which kind of message is being output. A consumer can look for specific fields in the json object (eg "message"), but there's no guarantee that in future some other kind of output will have a field of the same name. This PR adds a `"type"` field to add json outputs which can be used to unambiguously determine which kind of output it is. The mapping is: diagnostic: regular compiler diagnostics artifact: artifact notifications future_incompat: Report of future incompatibility unused_extern: Unused crate warnings/errors This matches the "internally tagged" representation for serde enums.
Configuration menu - View commit details
-
Copy full SHA for 5c81706 - Browse repository at this point
Copy the full SHA 5c81706View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62ad57b - Browse repository at this point
Copy the full SHA 62ad57bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54267dd - Browse repository at this point
Copy the full SHA 54267ddView commit details -
Use serde_json::to_writer for JsonEmitter::emit
Avoids an unnecessary intermediate string.
Configuration menu - View commit details
-
Copy full SHA for 00adbb2 - Browse repository at this point
Copy the full SHA 00adbb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for da3df9c - Browse repository at this point
Copy the full SHA da3df9cView commit details
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8f08458 - Browse repository at this point
Copy the full SHA 8f08458View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8aa4fb5 - Browse repository at this point
Copy the full SHA 8aa4fb5View commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe50c53 - Browse repository at this point
Copy the full SHA fe50c53View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.