Make create_def a side effect instead of marking the entire query as always red #115613

oli-obk · 2023-09-06T16:25:48Z

Before this PR:

query A creates def id D
query A is marked as depending on the always-red node, meaning it will always get re-run
in the next run of rustc: query A is not loaded from the incremental cache, but rerun

After this PR:

query A creates def id D
query system registers this a side effect (just like we collect diagnostics to re-emit them without running a query)
in the next run of rustc: query A is loaded from the incremental cache and its side effect is run (thus re-creating def id D without running query A)

r? @cjgillot

TODO:

need to make feeding queries a side effect, too. At least ones that aren't written to disk.
need to re-feed the def_span query
many more tests

cjgillot · 2023-09-06T16:36:33Z

Another tricky case:

ensure() query A -> executes side-effect from the cache;
fetch query A's result -> calls the provider for A -> gets to create_def -> ?

We wouldn't want to create 2 definitions where we only ask for one.

oli-obk · 2023-09-06T16:41:29Z

Huh... why does that happen? Shouldn't we already be getting weird diagnostics in that case?

cjgillot · 2023-09-06T16:50:01Z

This happens if we don't have the result of A in the on-disk cache, but still need it later.
IIUC, diagnostic deduplication catches it, so there is no observable effect.

cjgillot · 2023-09-06T16:51:45Z

More precisely: the first call is ensure(), so we don't attempt to compute the result, but still mark the dep-node as green and re-execute side effects. The second call is get(), so we need the result, we don't find it in the on-disk cache, and compute it the only way we know, by calling the provider function.

cjgillot · 2023-09-06T16:54:43Z

The logic is the fallback case in try_load_from_disk_and_cache_in_memory.

oli-obk · 2023-09-06T18:04:09Z

Thanks. I really need to dig into ensure and all its behaviours.

oli-obk · 2023-09-07T09:36:55Z

More precisely: the first call is ensure(), so we don't attempt to compute the result, but still mark the dep-node as green and re-execute side effects. The second call is get(), so we need the result, we don't find it in the on-disk cache, and compute it the only way we know, by calling the provider function.

I did some testing and a code dive, and I don't think that's what's happening.

ensure does not execute side effects. It checks if something is in the cache, and if not, executes that query immediately. The cache lookup itself doesn't perform any actions but set up the dep graph dependency in case of a cache hit.

cjgillot · 2023-09-07T10:56:29Z

ensure() calls get_query_incr with QueryMode::Ensure, which calls ensure_must_run, which calls try_mark_green, which calls try_mark_previous_green, which calls emit_side_effects.

oli-obk · 2023-09-07T11:12:14Z

yay, with this hint I was able to produce an example that actually exhibits an issue

index out of bounds: the len is 9 but the index is 9

oh wait... I even have this issue without doing any other changes to rustc. So it's not even ensure related yet

bors · 2023-09-22T03:24:02Z

☔ The latest upstream changes (presumably #115920) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2023-09-25T10:41:55Z

The difficulty is to know when to skip creating the DefId and reuse the one created by side-effect replay.

What about adding a new variant Replay to TaskDepsRef?
That variant would hold the list of definitions created by this query in the previous invocation. The nth call to create_def in the query would return the nth DefId in that list.

oli-obk · 2023-09-25T15:04:48Z

Thanks! I was thinking about doing

The nth call to create_def in the query would return the nth DefId in that list.

but didn't know how. I'll investigate the TaskDepsRef solution you hinted at.

bors · 2024-02-16T10:24:59Z

☔ The latest upstream changes (presumably #120486) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2024-02-16T17:04:26Z

@cjgillot I implemented replaying, and that fixes the issues I was able to coax out of incremental tests, could you have a look? I'll keep working on it and adding more tests, but I think I could benefit from a review

@bors try @rust-timer queue

oli-obk · 2025-04-26T15:06:41Z

Yay, not even a regression anymore. Now I just need to figure out if there are still query feeding issues and how to resolve them

run A -> feed B
force A but do not replay -> where's the value of B?

oli-obk · 2025-05-08T11:33:34Z

@bors try @rust-timer queue

Make create_def a side effect instead of marking the entire query as always red Before this PR: * query A creates def id D * query A is marked as depending on the always-red node, meaning it will always get re-run * in the next run of rustc: query A is not loaded from the incremental cache, but rerun After this PR: * query A creates def id D * query system registers this a side effect (just like we collect diagnostics to re-emit them without running a query) * in the next run of rustc: query A is loaded from the incremental cache and its side effect is run (thus re-creating def id D without running query A) r? `@cjgillot` TODO: * [ ] need to make feeding queries a side effect, too. At least ones that aren't written to disk. * [ ] need to re-feed the `def_span` query * [ ] many more tests

bors · 2025-05-08T11:34:49Z

⌛ Trying commit fc7e56d with merge 7e4699b...

bors · 2025-05-08T13:39:55Z

☀️ Try build successful - checks-actions
Build commit: 7e4699b (7e4699b549dea8f2d757eedc700b8b7920960b79)

rust-timer · 2025-05-08T15:14:45Z

Finished benchmarking commit (7e4699b): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

hyper-1.6.0

❗ ❗ ❗ ❗ ❗

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 1.0%]	16
Regressions ❌ (secondary)	0.5%	[0.2%, 0.8%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-1.0%, -0.8%]	4
All ❌✅ (primary)	0.3%	[0.2%, 1.0%]	16

Max RSS (memory usage)

Results (primary -0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 1.6%]	9
Regressions ❌ (secondary)	5.7%	[5.7%, 5.7%]	1
Improvements ✅ (primary)	-0.8%	[-1.9%, -0.4%]	12
Improvements ✅ (secondary)	-2.1%	[-2.3%, -2.0%]	3
All ❌✅ (primary)	-0.0%	[-1.9%, 1.6%]	21

Cycles

Results (primary -0.1%, secondary 4.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.6%, 1.1%]	4
Regressions ❌ (secondary)	4.2%	[2.5%, 5.9%]	2
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.4%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.7%, 1.1%]	12

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.841s -> 772.78s (0.12%)
Artifact size: 365.34 MiB -> 365.25 MiB (-0.02%)

oli-obk · 2025-05-08T15:22:42Z

The instruction count regressions are all coupled with wall time improvements.

There are real wall time regressions, but also improvements. I'd say overall it's a wash. Now I just need to see why hyper stops compiling lol

thread 'rustc' panicked at /rustc/7e4699b549dea8f2d757eedc700b8b7920960b79/compiler/rustc_query_system/src/dep_graph/graph.rs:644:13:
    forcing query with already existing `DepNode`
    - query-key: DefId(0:5121 ~ hyper[00ec]::body::incoming::{impl#3}::send_trailers::{opaque#0}::'_)
    - dep-node: def_span(hyper[00ec]::body::incoming::{impl#3}::send_trailers::{opaque#0}::'_)
    stack backtrace:
       0:     0x7ffff5142ca3 - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h843bbfd82b67dbdc
       1:     0x7ffff57f5947 - core::fmt::write::hd8c0d6ebfc44b2d4
       2:     0x7ffff6866d11 - std::io::Write::write_fmt::h5b8c479a0a891d96
       3:     0x7ffff5142b02 - std::sys::backtrace::BacktraceLock::print::hf6561a214a42649d
       4:     0x7ffff51466fa - std::panicking::default_hook::{{closure}}::hefab48d99c863da0
       5:     0x7ffff514627f - std::panicking::default_hook::h8c9a67b2624f9598
       6:     0x7ffff4175243 - std[3bc09ca882a9900e]::panicking::update_hook::<alloc[26935528e868a007]::boxed::Box<rustc_driver_impl[3855747714377aab]::install_ice_hook::{closure#1}>>::{closure#0}
       7:     0x7ffff5146f73 - std::panicking::rust_panic_with_hook::h47f5c8be0d2f3f06
       8:     0x7ffff5146c6a - std::panicking::begin_panic_handler::{{closure}}::h9f5fea5a52b8aa7f
       9:     0x7ffff5143179 - std::sys::backtrace::__rust_end_short_backtrace::he85991374d8d1de3
      10:     0x7ffff514692d - __rustc[7fca0b3884520f6e]::rust_begin_unwind
      11:     0x7ffff1a78fa0 - core::panicking::panic_fmt::ha41e83c5413d3f79
      12:     0x7ffff4010d35 - <rustc_query_system[d43e9aa0b402961a]::dep_graph::graph::DepGraphData<_>>::assert_dep_node_not_yet_allocated_in_current_session::panic_cold_display::<alloc[26935528e868a007]::string::String>
      13:     0x7ffff5afc30e - rustc_query_system[d43e9aa0b402961a]::query::plumbing::try_execute_query::<rustc_query_impl[cd24fe2d0275ca9e]::DynamicConfig<rustc_query_system[d43e9aa0b402961a]::query::caches::DefIdCache<rustc_middle[53e9a5506c571025]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[cd24fe2d0275ca9e]::plumbing::QueryCtxt, true>
      14:     0x7ffff5af8c30 - rustc_query_impl[cd24fe2d0275ca9e]::query_impl::def_span::get_query_incr::__rust_end_short_backtrace
      15:     0x7ffff5d668d2 - <rustc_metadata[b7d544d8b75375ac]::rmeta::encoder::EncodeContext>::encode_def_ids
      16:     0x7ffff5d4ca41 - <rustc_metadata[b7d544d8b75375ac]::rmeta::encoder::EncodeContext>::encode_crate_root
      17:     0x7ffff6718fb0 - rustc_metadata[b7d544d8b75375ac]::rmeta::encoder::encode_metadata
      18:     0x7ffff69a5b83 - rustc_metadata[b7d544d8b75375ac]::fs::encode_and_write_metadata
      19:     0x7ffff69a0df4 - <rustc_interface[d603959c4b1939b1]::queries::Linker>::codegen_and_build_linker
      20:     0x7ffff699ea38 - rustc_interface[d603959c4b1939b1]::passes::create_and_enter_global_ctxt::<core[a6f1d2c9471df5d6]::option::Option<rustc_interface[d603959c4b1939b1]::queries::Linker>, rustc_driver_impl[3855747714377aab]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}
      21:     0x7ffff689c2a6 - rustc_interface[d603959c4b1939b1]::interface::run_compiler::<(), rustc_driver_impl[3855747714377aab]::run_compiler::{closure#0}>::{closure#1}
      22:     0x7ffff68609be - std[3bc09ca882a9900e]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[d603959c4b1939b1]::util::run_in_thread_with_globals<rustc_interface[d603959c4b1939b1]::util::run_in_thread_pool_with_globals<rustc_interface[d603959c4b1939b1]::interface::run_compiler<(), rustc_driver_impl[3855747714377aab]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
      23:     0x7ffff6860e34 - <<std[3bc09ca882a9900e]::thread::Builder>::spawn_unchecked_<rustc_interface[d603959c4b1939b1]::util::run_in_thread_with_globals<rustc_interface[d603959c4b1939b1]::util::run_in_thread_pool_with_globals<rustc_interface[d603959c4b1939b1]::interface::run_compiler<(), rustc_driver_impl[3855747714377aab]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[a6f1d2c9471df5d6]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
      24:     0x7ffff686222b - std::sys::pal::unix::thread::Thread::new::thread_start::h1ebe2cb76ad45bd5
      25:     0x7ffff01cc6db - start_thread
                                   at /build/glibc-CVJwZb/glibc-2.27/nptl/pthread_create.c:463:0
      26:     0x7fffefef561f - __clone
                                   at /build/glibc-CVJwZb/glibc-2.27/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95:0
      27:                0x0 - <unknown>
    
    error: the compiler unexpectedly panicked. this is a bug.
    
    note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
    
    note: please make sure that you have updated to the latest nightly
    
    note: please attach the file at `/tmp/.tmpXTFFOD/rustc-ice-2025-05-08T14_14_47-5024.txt` to your bug report
    
    note: compiler flags: --crate-type lib -C embed-bitcode=no -C debuginfo=2 -C incremental=[REDACTED] -Z incremental-verify-ich -Z self-profile=/tmp/.tmpXTFFOD/self-profile-output-5017-1746713687554
    
    note: some of the compiler flags provided by cargo are hidden
    
    query stack during panic:
    #0 [def_span] looking up span for `body::incoming::<impl at src/body/incoming.rs:351:1: 351:12>::send_trailers::{opaque#0}::'_`
    end of query stack
    thread 'main' panicked at collector/src/bin/rustc-fake.rs:31:5:
    command did not complete successfully: LC_NUMERIC="C" RUSTC_FORCE_INCR_COMP_ARTIFACT_HEADER="rustc-perf" RUSTC_FORCE_RUSTC_VERSION="rustc-perf" "perf" "stat" "-x;" "-e" "instructions:u,cycles:u,task-clock,cpu-clock,faults,context-switches,branch-misses,cache-misses" "--log-fd" "1" "setarch" "x86_64" "-R" "/home/collector/rustc-perf/cache/7e4699b549dea8f2d757eedc700b8b7920960b79/bin/rustc" "--crate-name" "hyper" "--edition=2021" "src/lib.rs" "--error-format=json" "--json=diagnostic-rendered-ansi,artifacts,future-incompat" "--crate-type" "lib" "--emit=dep-info,metadata" "-C" "embed-bitcode=no" "-C" "debuginfo=2" "--warn=unexpected_cfgs" "--check-cfg" "cfg(hyper_unstable_tracing)" "--check-cfg" "cfg(hyper_unstable_ffi)" "--cfg" "feature=\"client\"" "--cfg" "feature=\"default\"" "--cfg" "feature=\"full\"" "--cfg" "feature=\"http1\"" "--cfg" "feature=\"http2\"" "--cfg" "feature=\"server\"" "--check-cfg" "cfg(docsrs,test)" "--check-cfg" "cfg(feature, values(\"capi\", \"client\", \"default\", \"ffi\", \"full\", \"http1\", \"http2\", \"nightly\", \"server\", \"tracing\"))" "-C" "metadata=4b197943049a7554" "-C" "extra-filename=-a84533cd2c2b70c8" "--out-dir" "/tmp/.tmpXTFFOD/target/debug/deps" "-L" "dependency=/tmp/.tmpXTFFOD/target/debug/deps" "--extern" "bytes=/tmp/.tmpXTFFOD/target/debug/deps/libbytes-41909bdff0288c17.rmeta" "--extern" "futures_channel=/tmp/.tmpXTFFOD/target/debug/deps/libfutures_channel-c83de858d5464c85.rmeta" "--extern" "futures_util=/tmp/.tmpXTFFOD/target/debug/deps/libfutures_util-3bbec5c951516809.rmeta" "--extern" "h2=/tmp/.tmpXTFFOD/target/debug/deps/libh2-9d9f848dfde867e9.rmeta" "--extern" "http=/tmp/.tmpXTFFOD/target/debug/deps/libhttp-58ce258cce83aa9f.rmeta" "--extern" "http_body=/tmp/.tmpXTFFOD/target/debug/deps/libhttp_body-9031adf98ad18672.rmeta" "--extern" "httparse=/tmp/.tmpXTFFOD/target/debug/deps/libhttparse-ed330500d3ff5544.rmeta" "--extern" "httpdate=/tmp/.tmpXTFFOD/target/debug/deps/libhttpdate-785a8fde9f31b304.rmeta" "--extern" "itoa=/tmp/.tmpXTFFOD/target/debug/deps/libitoa-552ebf7bdf4f013a.rmeta" "--extern" "pin_project_lite=/tmp/.tmpXTFFOD/target/debug/deps/libpin_project_lite-d5d269c14b1ea46f.rmeta" "--extern" "smallvec=/tmp/.tmpXTFFOD/target/debug/deps/libsmallvec-c5f88e6cd6396457.rmeta" "--extern" "tokio=/tmp/.tmpXTFFOD/target/debug/deps/libtokio-48b9a2e8785b0e4c.rmeta" "--extern" "want=/tmp/.tmpXTFFOD/target/debug/deps/libwant-abca090310cbd894.rmeta" "-C" "incremental=/tmp/.tmpXTFFOD/incremental-state" "-Adeprecated" "-Aunknown-lints" "-Zincremental-verify-ich" "-Zself-profile=/tmp/.tmpXTFFOD/self-profile-output-5017-1746713687554"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    error: could not compile `hyper` (lib)

…o we can reliably recreate the same `DefId` over and over again Recreate `DefId`s when a cached query gets replayed

oli-obk · 2025-05-08T15:25:24Z

@bors try @rust-timer queue

Make create_def a side effect instead of marking the entire query as always red Before this PR: * query A creates def id D * query A is marked as depending on the always-red node, meaning it will always get re-run * in the next run of rustc: query A is not loaded from the incremental cache, but rerun After this PR: * query A creates def id D * query system registers this a side effect (just like we collect diagnostics to re-emit them without running a query) * in the next run of rustc: query A is loaded from the incremental cache and its side effect is run (thus re-creating def id D without running query A) r? `@cjgillot` TODO: * [ ] need to make feeding queries a side effect, too. At least ones that aren't written to disk. * [ ] need to re-feed the `def_span` query * [ ] many more tests

bors · 2025-05-08T15:26:38Z

⌛ Trying commit c5f7d12 with merge 20a93fc35f133ff7ced8e27d35a882c46abc2029...

bors · 2025-05-08T17:34:01Z

☀️ Try build successful - checks-actions
Build commit: 20a93fc (20a93fc35f133ff7ced8e27d35a882c46abc2029)

rust-timer · 2025-05-08T19:07:52Z

Finished benchmarking commit (20a93fc): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

hyper-1.6.0

❗ ❗ ❗ ❗ ❗

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 1.1%]	15
Regressions ❌ (secondary)	0.6%	[0.4%, 0.8%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-1.1%, -0.3%]	5
All ❌✅ (primary)	0.3%	[0.2%, 1.1%]	15

Max RSS (memory usage)

Results (primary -0.0%, secondary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 3.1%]	12
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-1.6%	[-8.2%, -0.4%]	7
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-0.0%	[-8.2%, 3.1%]	19

Cycles

Results (primary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 1.0%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-1.2%, 1.0%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.853s -> 774.128s (0.16%)
Artifact size: 365.33 MiB -> 365.27 MiB (-0.02%)

rustbot assigned cjgillot Sep 6, 2023

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2023

oli-obk mentioned this pull request Sep 16, 2023

Tracking Issue for infallible promotion #80619

Closed

2 tasks

oli-obk mentioned this pull request Oct 27, 2023

Create definitions for promoted constants. #111693

Closed

oli-obk mentioned this pull request Dec 5, 2023

feed def_span in resolver #118633

Closed

oli-obk force-pushed the create_def_forever_red branch from 6f8f71c to a7f29ee Compare February 14, 2024 12:42

oli-obk force-pushed the create_def_forever_red branch 2 times, most recently from 6d6b1eb to 6831868 Compare February 16, 2024 17:00

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 16, 2024

rustbot removed the perf-regression Performance regression. label Apr 26, 2025

oli-obk force-pushed the create_def_forever_red branch from 6d5d29c to fc7e56d Compare May 8, 2025 11:20

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 8, 2025

oli-obk and others added 6 commits May 8, 2025 15:24

Add regression test

3a7983e

Remove a now-useless PhantomData

1158db7

Move disambiguator increment to the DisambiguatorState type`

cff0782

Make create_def invoke a helper query if used from a recorded query

c76c5bb

Prep query system for adding more side effects

1d0c251

Also store the DefPathHash as part of a DefId creation side effect, s…

c5f7d12

…o we can reliably recreate the same `DefId` over and over again Recreate `DefId`s when a cached query gets replayed

oli-obk force-pushed the create_def_forever_red branch from fc7e56d to c5f7d12 Compare May 8, 2025 15:25

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make create_def a side effect instead of marking the entire query as always red #115613

Make create_def a side effect instead of marking the entire query as always red #115613

oli-obk commented Sep 6, 2023 •

edited

Loading

cjgillot commented Sep 6, 2023

oli-obk commented Sep 6, 2023

cjgillot commented Sep 6, 2023

cjgillot commented Sep 6, 2023

cjgillot commented Sep 6, 2023

oli-obk commented Sep 6, 2023

oli-obk commented Sep 7, 2023

cjgillot commented Sep 7, 2023

oli-obk commented Sep 7, 2023 •

edited

Loading

bors commented Sep 22, 2023

cjgillot commented Sep 25, 2023

oli-obk commented Sep 25, 2023

bors commented Feb 16, 2024

oli-obk commented Feb 16, 2024

This comment has been minimized.

oli-obk commented Apr 26, 2025

oli-obk commented May 8, 2025

This comment has been minimized.

bors commented May 8, 2025

bors commented May 8, 2025

This comment has been minimized.

rust-timer commented May 8, 2025

oli-obk commented May 8, 2025 •

edited

Loading

oli-obk commented May 8, 2025

This comment has been minimized.

bors commented May 8, 2025

bors commented May 8, 2025

This comment has been minimized.

rust-timer commented May 8, 2025

Make create_def a side effect instead of marking the entire query as always red #115613

Are you sure you want to change the base?

Make create_def a side effect instead of marking the entire query as always red #115613

Conversation

oli-obk commented Sep 6, 2023 • edited Loading

cjgillot commented Sep 6, 2023

oli-obk commented Sep 6, 2023

cjgillot commented Sep 6, 2023

cjgillot commented Sep 6, 2023

cjgillot commented Sep 6, 2023

oli-obk commented Sep 6, 2023

oli-obk commented Sep 7, 2023

cjgillot commented Sep 7, 2023

oli-obk commented Sep 7, 2023 • edited Loading

bors commented Sep 22, 2023

cjgillot commented Sep 25, 2023

oli-obk commented Sep 25, 2023

bors commented Feb 16, 2024

oli-obk commented Feb 16, 2024

This comment has been minimized.

oli-obk commented Apr 26, 2025

oli-obk commented May 8, 2025

This comment has been minimized.

bors commented May 8, 2025

bors commented May 8, 2025

This comment has been minimized.

rust-timer commented May 8, 2025

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

oli-obk commented May 8, 2025 • edited Loading

oli-obk commented May 8, 2025

This comment has been minimized.

bors commented May 8, 2025

bors commented May 8, 2025

This comment has been minimized.

rust-timer commented May 8, 2025

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

oli-obk commented Sep 6, 2023 •

edited

Loading

oli-obk commented Sep 7, 2023 •

edited

Loading

oli-obk commented May 8, 2025 •

edited

Loading