Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit unused doc comment warnings for pat and expr fields #115478

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Emit unused doc comment warnings for pat and expr fields #115478

merged 2 commits into from
Sep 3, 2023

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Sep 2, 2023

Fixes #115462

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gurry
Copy link
Contributor Author

gurry commented Sep 2, 2023 •
edited
Loading

@rustbot label -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@GuillaumeGomez
Copy link
Member

Needs to fix formatting (run x.py fmt for that) but otherwise looks good.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gurry
Copy link
Contributor Author

gurry commented Sep 3, 2023

@rustbot label +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2023
@gurry gurry marked this pull request as ready for review September 3, 2023 03:15
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

@gurry
Copy link
Contributor Author

gurry commented Sep 3, 2023

@rustbot review

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 3, 2023

📌 Commit a0a7173 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2023
@bors
Auto merge of rust-lang#115510 - GuillaumeGomez:rollup-wh719bn, r=Gui…
2a1af89 
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115478 (Emit unused doc comment warnings for pat and expr fields)
 - rust-lang#115490 (rustdoc: update comment in search.js for rust-lang#107629)
 - rust-lang#115503 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3db7fc1 into rust-lang:master Sep 3, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@gurry gurry deleted the 115462-exprfield-no-warn branch September 4, 2023 02:51
@shekhirin shekhirin mentioned this pull request Sep 4, 2023
Merged
@adpaco-aws adpaco-aws mentioned this pull request Sep 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

PatField and ExprField produce no warning for #[doc(...)] attribute
7 participants
@gurry @rustbot @rust-log-analyzer @GuillaumeGomez @compiler-errors @bors @wesleywiser