Skip to content

Conversation

@ShE3py
Copy link
Contributor

@ShE3py ShE3py commented Aug 20, 2023

Complements #114968, closes #114949.

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 20, 2023
@thomcc
Copy link
Member

thomcc commented Aug 20, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 20, 2023

📌 Commit f8a2f31 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2023
@bors
Copy link
Collaborator

bors commented Aug 21, 2023

⌛ Testing commit f8a2f31 with merge c40cfcf...

@bors
Copy link
Collaborator

bors commented Aug 21, 2023

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing c40cfcf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2023
@bors bors merged commit c40cfcf into rust-lang:master Aug 21, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c40cfcf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-2.7% [-2.9%, -2.5%] 2
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.684s -> 635.443s (-0.04%)
Artifact size: 347.04 MiB -> 347.02 MiB (-0.01%)

@ShE3py ShE3py deleted the getsetenv-miri-test branch May 3, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible data race & use-after-free in std::env::var for unix implementation

6 participants