Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update thiserror to version >= 1.0.46 #114944

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

lqd
Copy link
Member

@lqd lqd commented Aug 17, 2023

1.0.46 version is the one with the workaround for #114839. I'm also encountering this issue, so let's update the dependency so that everyone doesn't have to ./x clean.

Fixes #114839.

r? @RalfJung

this version is the one containing the workaround for the provider API
changes on nightly
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@lqd lqd changed the title update thsiserror to version >= 1.0.46 update thiserror to version >= 1.0.46 Aug 17, 2023
@RalfJung
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit df3819b has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2023
Rollup of 5 pull requests

Successful merges:

 - rust-lang#113715 (Unstable Book: update `lang_items` page and split it)
 - rust-lang#114897 (Partially revert rust-lang#107200)
 - rust-lang#114913 (Fix suggestion for attempting to define a string with single quotes)
 - rust-lang#114931 (Revert PR rust-lang#114052 to fix invalid suggestion)
 - rust-lang#114944 (update `thiserror` to version >= 1.0.46)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit df877c0 into rust-lang:master Aug 18, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 18, 2023
@lqd lqd deleted the fix-thiserror branch August 18, 2023 05:52
@RalfJung RalfJung mentioned this pull request Aug 20, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2023
update anyhow

This is the anyhow version of rust-lang#114944, fixing Miri builds with an existing x.py cache by including dtolnay/anyhow#320.

r? `@lqd`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build caching issue: stage 0 fails in thiserror with "unresolved imports std::any::Demand, std::any::Provider"
4 participants