Enable tests on rustc_codegen_ssa #114431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2023
Enable tests on rustc_codegen_ssa This enables unittests in rustc_codegen_ssa. There are some tests, primarily in [`back/rpath/tests.rs`](https://github.com/rust-lang/rust/blob/HEAD/compiler/rustc_codegen_ssa/src/back/rpath/tests.rs) that haven't ever been running since the unittests are disabled. From what I can tell, this was just a consequence of how things evolved. When testing was initially added in rust-lang#33282, `librustc_trans` had test=false because it didn't have any tests. `rustc_codegen_ssa` eventually split off from that (rust-lang#55627), and the rpath module eventually got merged in too (from `librustc_back` where it used to live). That migration didn't enable the tests. This also includes some fluent diagnostic tests, though I'm not sure what exactly they are testing.
This was referenced Aug 3, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113534 (Forbid old-style `simd_shuffleN` intrinsics) - rust-lang#113999 (Specify macro is invalid in certain contexts) - rust-lang#114348 (Migrate GUI colors test to original CSS color format) - rust-lang#114373 (unix/kernel_copy.rs: copy_file_range_candidate allows empty output files) - rust-lang#114404 (Migrate GUI colors test to original CSS color format) - rust-lang#114409 (builtin impl confirmation wuhu) - rust-lang#114429 (compiletest: Handle non-utf8 paths (fix FIXME)) - rust-lang#114431 (Enable tests on rustc_codegen_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables unittests in rustc_codegen_ssa. There are some tests, primarily in
back/rpath/tests.rsthat haven't ever been running since the unittests are disabled. From what I can tell, this was just a consequence of how things evolved. When testing was initially added in #33282,librustc_transhad test=false because it didn't have any tests.rustc_codegen_ssaeventually split off from that (#55627), and the rpath module eventually got merged in too (fromlibrustc_backwhere it used to live). That migration didn't enable the tests.This also includes some fluent diagnostic tests, though I'm not sure what exactly they are testing.