Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #112465

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Rollup of 3 pull requests #112465

merged 8 commits into from
Jun 9, 2023

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

compiler-errors and others added 8 commits June 8, 2023 23:38
@compiler-errors
deduplicate identical region constraints
d5e25d4
@GuillaumeGomez
List matching impls on type aliases
4b1d13d
@GuillaumeGomez
Add regression test for rust-lang#32077
6f552c8
@GuillaumeGomez
Fix intra-doc links from pointer appearing in windows HANDLE type alias
2ce7cd9
@eval-exec
Improve document of unsafe_code lint
30f84c4 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@GuillaumeGomez
Rollup merge of rust-lang#112260 - eval-exec:exec/fix-unsafe_code_lin…
a7f46af 
…t, r=WaffleLapkin

Improve document of `unsafe_code` lint

This PR add another `unsafe_code` lint example, want to close rust-lang#111967
@GuillaumeGomez
Rollup merge of rust-lang#112429 - GuillaumeGomez:ty-alias-impls, r=n…
f83c8e4 
…otriddle,lcnr

[rustdoc] List matching impls on type aliases

Fixes rust-lang#32077.

Thanks a lot to ``@lcnr`` who helped me a lot with this fix!

cc ``@notriddle``
r? ``@lcnr``
@GuillaumeGomez
Rollup merge of rust-lang#112442 - compiler-errors:next-solver-dedupl…
4ef7257 
…icate-region-constraints, r=lcnr

Deduplicate identical region constraints in new solver

the new solver doesn't track whether we've already proven a goal like the fulfillment context's obligation forest does, so we may be instantiating a canonical response (and specifically, its nested region obligations) quite a few times.

This may lead to exponentially gathering up identical region constraints for things like auto traits, so let's deduplicate region constraints when in `compute_external_query_constraints`.

r? ``@lcnr``
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Jun 9, 2023
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Contributor

bors commented Jun 9, 2023

📌 Commit 4ef7257 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@bors
Copy link
Contributor

bors commented Jun 9, 2023

⌛ Testing commit 4ef7257 with merge 397641f...

@bors
Copy link
Contributor

bors commented Jun 9, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 397641f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2023
@bors bors merged commit 397641f into rust-lang:master Jun 9, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 9, 2023
@GuillaumeGomez GuillaumeGomez deleted the rollup-gyh5buc branch June 9, 2023 18:54
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#112442 5d8e156694f22521f45f4d58a8f330fbfb703ede
#112429 da6e5f4bfa26d659d0c3cf6bc37c89c044e717dc
#112260 e1f01ccf2d21486a825ee9319e368723292f4f15

previous master: d7ad9d9797

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (397641f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.2% [0.4%, 14.8%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.2% [0.4%, 14.8%] 6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 6.8% [3.3%, 12.5%] 3
Regressions ❌
(secondary)		 2.2% [2.1%, 2.4%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 6.8% [3.3%, 12.5%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.935s -> 649.669s (-0.04%)

@rustbot rustbot added the perf-regression Performance regression. label Jun 9, 2023
@lqd
Copy link
Member

lqd commented Jun 9, 2023

Regressions are on doc builds, which look expected from #112429

@GuillaumeGomez
Copy link
Member Author

Confirmed. We forgot to run perf-check beforehand...

@lqd
Copy link
Member

lqd commented Jun 9, 2023

Great, thank you.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @bors @rust-timer @lqd @rustbot @compiler-errors @eval-exec