Rollup of 9 pull requests #112415
Merged
Rollup of 9 pull requests #112415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in 12ac719, this logic always passed --cpu-features, even when the value was the empty string.
replace build with check Co-authored-by: Michael Goulet <michael@errs.io> use appropriate test name
Migrate item_opaque_type to Askama Fix wrap_item parameters Fix to write
…laumeGomez Migrate `item_opaque_ty` to Askama This PR migrates `item_opaque_ty` to Askama Refers: rust-lang#108868
…trochenkov Avoid passing --cpu-features when empty Added in 12ac719, this logic always passed --cpu-features, even when the value was the empty string.
…rtlarsan68 bootstrap: remove dependency `is-terminal`
…lor-12, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`
…rrors Add a test for rust-lang#105709 Closes rust-lang#105709
…errors Fix ICE for while loop with assignment condition with LHS place expr Fixes rust-lang#112385.
…henkov Remove accidental comment Left this in in rust-lang#110092 while debugging, thanks to `@WaffleLapkin` for spotting
…s, r=compiler-errors Track more diagnostics in `rustc_expand` I wish we could lint this somehow...
…=Nilstrieb Don't `use compile_error as print` I've spent **1.5 hours** debugging this while trying to compile rust-lang#112400, if we use `compile_error!`, we should not just forward user input to it, but issue a reasonable error message. The better solution would be to use a lint like `clippy::print_stdout`, but since we don't have clippy in CI, let's at least make the macro error better. Also note that some functions called here actually do use `println` (see for example `print_type_sizes` function).
rustbot
added
S-waiting-on-review
|
@bors r+ p=9 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: a0df04c0f2 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (e740925): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.385s -> 648.715s (0.05%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
item_opaque_tyto Askama #112034 (Migrateitem_opaque_tyto Askama)is-terminal#112309 (bootstrap: remove dependencyis-terminal)rustc_expand#112396 (Track more diagnostics inrustc_expand)use compile_error as print#112401 (Don'tuse compile_error as print)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup