Skip to content

Rollup of 6 pull requests #112111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8d2beb5
Allow access to `OsStr` bytes
epage Mar 28, 2023
7f1a6cd
refactor: Remove redundant, private OsStr::bytes
epage May 13, 2023
7b92903
refactor: Remove bespoke from_os_str_bytes_unchecked
epage May 13, 2023
f9aaad0
docs: Add examples of OsStr safety violation
epage May 17, 2023
5d177af
docs: Clarify OsStr is self-synchronizing
epage May 17, 2023
e6a35c4
docs: Add missing period
epage May 20, 2023
5c780d9
Migrate to Askama
sladyn98 May 28, 2023
cfd0623
unique borrows are mutating uses
lcnr May 29, 2023
b573250
add tests
lcnr May 29, 2023
25f8f4c
add FIXME
lcnr May 29, 2023
6c18d1e
offset_of: Don't require type to be sized
clubby789 May 29, 2023
97d4a38
Remove `-Zcgu-partitioning-strategy`.
nnethercote May 28, 2023
66cf072
Merge `default.rs` into `mod.rs`.
nnethercote May 30, 2023
5ed0149
Rename `partitioning/mod.rs` as `partitioning.rs`.
nnethercote May 30, 2023
e3a039d
Better group RFC ui tests together
WaffleLapkin May 29, 2023
b694a03
Bless tidy root entry limit
WaffleLapkin May 29, 2023
e898e7c
Rollup merge of #109698 - epage:wtf, r=Amanieu
Dylan-DPC May 30, 2023
658bd78
Rollup merge of #112031 - sladyn98:migrate-proc-macro, r=GuillaumeGomez
Dylan-DPC May 30, 2023
9897757
Rollup merge of #112053 - nnethercote:rm-Zcpu-partitioning-strategy, …
Dylan-DPC May 30, 2023
02d58ab
Rollup merge of #112069 - clubby789:offset-of-sized-fields, r=WaffleL…
Dylan-DPC May 30, 2023
f00651c
Rollup merge of #112070 - lcnr:disjoint-closure-capture-ub, r=oli-obk
Dylan-DPC May 30, 2023
3b49aa0
Rollup merge of #112071 - WaffleLapkin:group-rfcs-tests, r=oli-obk
Dylan-DPC May 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove -Zcgu-partitioning-strategy.
This option was introduced three years ago, but it's never been
meaningfully used, and `default` is the only acceptable value.

Also, I think the `Partition` trait presents an interface that is too
closely tied to the existing strategy and would probably be wrong for
other strategies. (My rule of thumb is to not make something generic
until there are at least two instances of it, to avoid this kind of
problem.)

Also, I don't think providing multiple partitioning strategies to the
user is a good idea, because the compiler already has enough obscure
knobs.

This commit removes the option, along with the `Partition` trait, and
the `Partitioner` and `DefaultPartitioning` types. I left the existing
code in `compiler/rustc_monomorphize/src/partitioning/default.rs`,
though I could be persuaded that moving it into
`compiler/rustc_monomorphize/src/partitioning/mod.rs` is better.
  • Loading branch information
nnethercote committed May 30, 2023
commit 97d4a38de9fd6efb4588a7262cd9c66c2093e29f
Loading