Skip to content

Add test for RPIT defined with different hidden types with different substs #111947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

Add test for RPIT defined with different hidden types with different substs #111947

merged 1 commit into from
May 26, 2023

Conversation

@obeis
Copy link
Contributor

@obeis obeis commented May 25, 2023

Close #111943

@rustbot
Copy link
Collaborator

rustbot commented May 25, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 25, 2023
@obeis
Copy link
Contributor Author

obeis commented May 25, 2023

r? @compiler-errors

compiler-errors
compiler-errors reviewed May 25, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go in the impl-trait directory, and could use a better name... multiple-defining-usages-in-body? idk

@obeis obeis requested a review from compiler-errors May 25, 2023 21:01
compiler-errors
compiler-errors reviewed May 25, 2023
View reviewed changes
@obeis obeis requested a review from compiler-errors May 25, 2023 21:55
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 25, 2023

📌 Commit b37cdc6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2023
@compiler-errors compiler-errors mentioned this pull request May 26, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 26, 2023
@compiler-errors
Rollup merge of rust-lang#111947 - obeis:issue-111943, r=compiler-errors
91ddc05 
Add test for RPIT defined with different hidden types with different substs

Close rust-lang#111943
@matthiaskrgr matthiaskrgr mentioned this pull request May 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 26, 2023
@bors
Auto merge of rust-lang#111984 - matthiaskrgr:rollup-6u7ynyv, r=matth…
1221e43 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111384 (Fix linking Mac Catalyst by including LC_BUILD_VERSION in object files)
 - rust-lang#111899 (CGU cleanups)
 - rust-lang#111940 (Clarify safety concern of `io::Read::read` is only relevant in unsafe code)
 - rust-lang#111947 (Add test for RPIT defined with different hidden types with different substs)
 - rust-lang#111951 (Correct comment on privately uninhabited pattern.)

Failed merges:

 - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 39b633e into rust-lang:master May 26, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 26, 2023
@obeis obeis deleted the issue-111943 branch January 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

Add test for RPIT defined with different hidden types with different substs

5 participants

@obeis @rustbot @compiler-errors @bors @wesleywiser