Skip to content

Always name the return place. #111618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2023
Merged

Always name the return place. #111618

merged 1 commit into from
Jul 9, 2023

Conversation

@cjgillot
Copy link
Contributor

MIR opts more and more consider _0 as just another local, so there is no point in keeping the special case in debug-info logic.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 17, 2023

☔ The latest upstream changes (presumably #111556) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the name-return-place branch 2 times, most recently from 00978a5 to 8dfac29 Compare May 17, 2023 08:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot cjgillot force-pushed the name-return-place branch from b768e1e to c4e97a2 Compare May 17, 2023 09:50
@tmiasko
Copy link
Contributor

tmiasko commented May 18, 2023

r=me with commits squashed

@cjgillot cjgillot force-pushed the name-return-place branch from c4e97a2 to a60e707 Compare May 18, 2023 14:15
@cjgillot
Copy link
Contributor Author

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented May 18, 2023

📌 Commit a60e707 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 18, 2023
@Dylan-DPC
Rollup merge of rust-lang#111618 - cjgillot:name-return-place, r=tmiasko
7bc736c 
Always name the return place.

MIR opts more and more consider `_0` as just another local, so there is no point in keeping the special case in debug-info logic.
@Dylan-DPC Dylan-DPC mentioned this pull request May 18, 2023
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in #111732 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2023
@cjgillot cjgillot force-pushed the name-return-place branch from a60e707 to 6db8d20 Compare May 24, 2023 19:58
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2023
@tmiasko
Copy link
Contributor

tmiasko commented May 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 28, 2023

📌 Commit 6db8d205d831f3c9d7cb45b039cbb3f4134935df has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2023
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2023
@cjgillot cjgillot force-pushed the name-return-place branch 2 times, most recently from f014d94 to 7e75612 Compare June 3, 2023 09:40
@tmiasko
Copy link
Contributor

tmiasko commented Jun 18, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2023

📌 Commit 7e75612 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2023
@bors
Copy link
Collaborator

bors commented Jun 18, 2023

⌛ Testing commit 7e75612 with merge 71c21666f44026562fa3e1e0bc86b6031029ed62...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 18, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2023
@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Jun 27, 2023
@TaKO8Ki
Rollup merge of rust-lang#111618 - cjgillot:name-return-place, r=tmiasko
a5f5328 
Always name the return place.

MIR opts more and more consider `_0` as just another local, so there is no point in keeping the special case in debug-info logic.
@TaKO8Ki TaKO8Ki mentioned this pull request Jun 27, 2023
Closed
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 8, 2023

@bors r-
needs re-blessing

@cjgillot cjgillot force-pushed the name-return-place branch from 7e75612 to d7983a2 Compare July 8, 2023 13:39
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 8, 2023

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Jul 8, 2023

📌 Commit d7983a2 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 8, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2023
@bors
Auto merge of rust-lang#113508 - matthiaskrgr:rollup-xzrp4nt, r=matth…
a9eba8d 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111618 (Always name the return place.)
 - rust-lang#113247 (Add Tests for native wasm exceptions)
 - rust-lang#113273 (Use String or Int to set the opt level)
 - rust-lang#113469 (Remove `default_free_fn` feature)
 - rust-lang#113493 (additional io::copy specializations)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4406a92 into rust-lang:master Jul 9, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 9, 2023
@cjgillot cjgillot deleted the name-return-place branch July 9, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

8 participants

@cjgillot @rustbot @rust-log-analyzer @bors @tmiasko @matthiaskrgr @davidtwco @compiler-errors