Give better error when collecting into &[T]
#111612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
ChayimFriedman2
force-pushed
the
collect-into-slice-ref
branch
from
6357b6f to
83930ec
Compare
ChayimFriedman2
changed the title
&[T]&[T]
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#111501 (MIR drive-by cleanups) - rust-lang#111609 (Mark internal functions and traits unsafe to reflect preconditions) - rust-lang#111612 (Give better error when collecting into `&[T]`) - rust-lang#111756 (Rename `{drop,forget}_{copy,ref}` lints to more consistent naming) - rust-lang#111843 (move lcnr to only review types stuff) - rust-lang#111844 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of slice reference of
{integral}inrustc_on_unimplementedis hacky, but a proper solution requires changingFmtPrinterto add a parameter to print integers as{integral}and I didn't want to change it just forrustc_on_unimplemented. I can do that if requested, though.I'm open to better wording; this is the best I could come up with.