Handle error body in generator layout #111533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
clubby789
force-pushed
the
drop-tracking-error
branch
from
118f34a
to
80c0c28
Compare
|
Got this working with an Option instead, I can revert to the other approach if that's preferred |
clubby789
changed the title
cjgillot
reviewed
May 13, 2023
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
clubby789
force-pushed
the
drop-tracking-error
branch
from
80c0c28
to
f77971e
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107680 (Hide repr attribute from doc of types without guaranteed repr) - rust-lang#111488 (Use error term in projection if missing associated item in new solver) - rust-lang#111533 (Handle error body in generator layout) - rust-lang#111573 (Erase `ReError` properly) - rust-lang#111592 (Change Vec examples to not assert exact capacity except where it is guaranteed) - rust-lang#111610 (fix(diagnostic): wrap parens for ref impl trait param) - rust-lang#111642 ([rustdoc] Only keep impl blocks from bodies) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111468
I feel like making this query return
Option<GeneratorLayout>might be better but had some issues with that approach