Emit while_true lint spanning the entire loop condition

[Flying-Toast]

The lint that suggests loop {} instead of while true {} has functionality to 'pierce' parenthesis in cases like while (true) {}. In these cases, the emitted span only went to the hi of the true itself, not spanning the entire loop condition.

Before:

warning: denote infinite loops with `loop { ... }`
 --> /tmp/foobar.rs:2:5
  |
2 |     while ((((((true)))))) {}
  |     ^^^^^^^^^^^^^^^^ help: use `loop`
  |
  = note: `#[warn(while_true)]` on by default

After:

warning: denote infinite loops with `loop { ... }`
 --> /tmp/foobar.rs:2:5
  |
2 |     while ((((((true)))))) {}
  |     ^^^^^^^^^^^^^^^^^^^^^^ help: use `loop`
  |
  = note: `#[warn(while_true)]` on by default

This is especially a problem for rustfix.

[rustbot]

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

r? @compiler-errors @bors r+ rollup

[bors]

📌 Commit faa797e has been approved by compiler-errors

It is now in the queue for this repository.