Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: handle generics better when matching notable traits #108954

Merged
merged 5 commits into from
Mar 23, 2023
Merged

rustdoc: handle generics better when matching notable traits #108954

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c601585
rustdoc: move notable trait tests into their own directory
notriddle Mar 9, 2023
ee6b228
rustdoc: handle generics better when matching notable traits
notriddle Mar 9, 2023
86179c4
rustdoc: rename `Type::is_same` to `is_doc_subtype_of`
notriddle Mar 13, 2023
bfb66eb
rustdoc: fix comments in test
notriddle Mar 14, 2023
7f76084
Add clarifying comments
notriddle Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustdoc: fix comments in test
  • Loading branch information
@notriddle
notriddle authored Mar 14, 2023
commit bfb66eb4bb4ada8a0b4d48d73a93e8f5df0e54be
8 changes: 4 additions & 4 deletions tests/rustdoc/notable-trait/notable-trait-generics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#![feature(doc_notable_trait)]

// Notable traits SHOULD be shown when the `impl` has a generic type and the
// return type has a concrete type.
// Notable traits SHOULD NOT be shown when the `impl` has a concrete type and
// the return type has a generic type.
pub mod generic_return {
pub struct Wrapper<T>(T);

Expand All @@ -17,8 +17,8 @@ pub mod generic_return {
}
}

// Notable traits SHOULD NOT be shown when the `impl` has a concrete type and
// the return type has a generic type.
// Notable traits SHOULD be shown when the `impl` has a generic type and the
// return type has a concrete type.
pub mod generic_impl {
pub struct Wrapper<T>(T);

Expand Down