Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querify register_tools and post-expansion early lints #108806

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Querify register_tools and post-expansion early lints #108806

merged 2 commits into from
Mar 11, 2023

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Mar 6, 2023 •
edited
Loading

The 2 extra queries correspond to code that happen before and after macro expansion, and don't need the resolver to exist.

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2023
@cjgillot
Copy link
Contributor Author

cjgillot commented Mar 6, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2023
@bors
Copy link
Contributor

bors commented Mar 6, 2023

⌛ Trying commit c90fc10 with merge dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6...

@petrochenkov petrochenkov self-assigned this Mar 6, 2023
@bors
Copy link
Contributor

bors commented Mar 6, 2023

☀️ Try build successful - checks-actions
Build commit: dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6 (dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 6, 2023

☀️ Try build successful - checks-actions
Build commit: dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6 (dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6)

@rust-timer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov removed their assignment Mar 6, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dea5f39d649b0b6ca7c0fa4e7056a6b500dde8b6): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [1.7%, 5.4%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-3.2%, -2.2%] 3
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2023
@cjgillot cjgillot marked this pull request as ready for review March 6, 2023 22:13
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2023

📌 Commit c90fc10 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
@compiler-errors
Copy link
Member

Perf is neutral so

@bors rollup-

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#108806 - cjgillot:query-lints, r=davidtwco
cec77c1 
Querify register_tools and post-expansion early lints

The 2 extra queries correspond to code that happen before and after macro expansion, and don't need the resolver to exist.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2023
@bors
Auto merge of rust-lang#109019 - matthiaskrgr:rollup-ihjntil, r=matth…
8a73f50 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104363 (Make `unused_allocation` lint against `Box::new` too)
 - rust-lang#106633 (Stabilize `nonzero_min_max`)
 - rust-lang#106844 (allow negative numeric literals in `concat!`)
 - rust-lang#108071 (Implement goal caching with the new solver)
 - rust-lang#108542 (Force parentheses around `match` expression in binary expression)
 - rust-lang#108690 (Place size limits on query keys and values)
 - rust-lang#108708 (Prevent overflow through Arc::downgrade)
 - rust-lang#108739 (Prevent the `start_bx` basic block in codegen from having two `Builder`s at the same time)
 - rust-lang#108806 (Querify register_tools and post-expansion early lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit df50001 into rust-lang:master Mar 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 11, 2023
@cjgillot cjgillot deleted the query-lints branch March 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rustbot @rust-timer @bors @davidtwco @compiler-errors @petrochenkov