-
Notifications
You must be signed in to change notification settings - Fork 13.4k
lint/ctypes: ext. abi fn-ptr in internal abi fn #108611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 6 commits into
rust-lang:master
from
davidtwco:issue-94223-external-abi-fn-ptr-in-internal-abi-fn
Jul 3, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e3f90bc
lint/ctypes: ext. abi fn-ptr in internal abi fn
davidtwco eddfce5
abi: avoid ice for non-ffi-safe fn ptrs
davidtwco c75b080
lint/ctypes: multiple external fn-ptrs in ty
davidtwco 9137fea
lint/ctypes: check other types for ext. fn-ptr ty
davidtwco f1e2879
lint: stop normalizing types to avoid recur limits
davidtwco 2227422
lint: refactor to make logic a bit cleaner
davidtwco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// check-pass | ||
#![allow(improper_ctypes_definitions)] | ||
#![crate_type = "lib"] | ||
|
||
// Check that computing the fn abi for `bad`, with a external ABI fn ptr that is not FFI-safe, does | ||
// not ICE. | ||
|
||
pub fn bad(f: extern "C" fn([u8])) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
#![crate_type = "lib"] | ||
#![deny(improper_ctypes_definitions)] | ||
|
||
pub fn bad(f: extern "C" fn([u8])) {} | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
|
||
pub fn bad_twice(f: Result<extern "C" fn([u8]), extern "C" fn([u8])>) {} | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
//~^^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
|
||
struct BadStruct(extern "C" fn([u8])); | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
|
||
enum BadEnum { | ||
A(extern "C" fn([u8])), | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
} | ||
|
||
enum BadUnion { | ||
A(extern "C" fn([u8])), | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
} | ||
|
||
type Foo = extern "C" fn([u8]); | ||
//~^ ERROR `extern` fn uses type `[u8]`, which is not FFI-safe | ||
|
||
pub struct FfiUnsafe; | ||
|
||
#[allow(improper_ctypes_definitions)] | ||
extern "C" fn f(_: FfiUnsafe) { | ||
unimplemented!() | ||
} | ||
|
||
pub static BAD: extern "C" fn(FfiUnsafe) = f; | ||
//~^ ERROR `extern` fn uses type `FfiUnsafe`, which is not FFI-safe | ||
|
||
pub static BAD_TWICE: Result<extern "C" fn(FfiUnsafe), extern "C" fn(FfiUnsafe)> = Ok(f); | ||
//~^ ERROR `extern` fn uses type `FfiUnsafe`, which is not FFI-safe | ||
//~^^ ERROR `extern` fn uses type `FfiUnsafe`, which is not FFI-safe | ||
|
||
pub const BAD_CONST: extern "C" fn(FfiUnsafe) = f; | ||
//~^ ERROR `extern` fn uses type `FfiUnsafe`, which is not FFI-safe |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.