Skip to content

bootstrap: Update the output of the check descriptions #108463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

bootstrap: Update the output of the check descriptions #108463

merged 1 commit into from
Feb 27, 2023

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Feb 25, 2023

This should bring the output from x check in line with the changes in #108171

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 25, 2023
@clubby789
Copy link
Contributor Author

clubby789 commented Feb 25, 2023

Sample output 
> x check compiler/rustc --stage 0
Building bootstrap
[ ... ]
Checking stage0 library artifacts (x86_64-unknown-linux-gnu)
[ ... ]
Checking stage0 library test/bench/example targets (x86_64-unknown-linux-gnu)
[ ... ]
Checking stage0 compiler artifacts (x86_64-unknown-linux-gnu)
[ ... ]
> x check compiler/rustc --stage 1
Building bootstrap
[ ... ]
Building stage0 library artifacts (x86_64-unknown-linux-gnu) 
[ ... ]
Building compiler artifacts (stage0 -> stage1)
[ ... ]
Assembling stage1 compiler
Building stage1 library artifacts (x86_64-unknown-linux-gnu) 
[ ... ]
Checking stage1 compiler artifacts (x86_64-unknown-linux-gnu)
[ ... ]
> x check compiler/rustc --stage 2
Building bootstrap
[ ... ]
Building stage0 library artifacts (x86_64-unknown-linux-gnu) 
[ ... ]
Building compiler artifacts (stage0 -> stage1)
[ ... ]
Assembling stage1 compiler
Building stage1 library artifacts (x86_64-unknown-linux-gnu) 
[ ... ]
Building compiler artifacts (stage1 -> stage2)
[ ... ]
Assembling stage2 compiler
Uplifting library (stage1 -> stage2)
Checking stage2 compiler artifacts (x86_64-unknown-linux-gnu)
[ ... ]
Build completed successfully in 0:00:02
> x check library --stage 0
Building bootstrap
[ ... ]
Checking stage0 library artifacts (x86_64-unknown-linux-gnu)
[ ... ]
Checking stage0 library test/bench/example targets (x86_64-unknown-linux-gnu)
[ ... ]
Build completed successfully in 0:00:01
> x check library --stage 1
Building bootstrap
[ ... ]
Building stage0 library artifacts (x86_64-unknown-linux-gnu) 
[ ... ]
Building compiler artifacts (stage0 -> stage1)
[ ... ]
Assembling stage1 compiler
Checking stage1 library artifacts (x86_64-unknown-linux-gnu)
[ ... ]
Checking stage1 library test/bench/example targets (x86_64-unknown-linux-gnu)
[ ... ]

@albertlarsan68
Copy link
Member

albertlarsan68 commented Feb 26, 2023

This looks great.
Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

📌 Commit b30d0da has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#108463 - clubby789:update-check-output, r=a…
71ddfb0 
…lbertlarsan68

bootstrap: Update the output of the `check` descriptions

This should bring the output from `x check` in line with the changes in rust-lang#108171
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 26, 2023
Closed
@compiler-errors
Copy link
Member

compiler-errors commented Feb 26, 2023

@bors rollup

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 26, 2023
@compiler-errors
Rollup merge of rust-lang#108463 - clubby789:update-check-output, r=a…
ebf8c49 
…lbertlarsan68

bootstrap: Update the output of the `check` descriptions

This should bring the output from `x check` in line with the changes in rust-lang#108171
@compiler-errors compiler-errors mentioned this pull request Feb 26, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2023
@bors
Auto merge of rust-lang#108521 - matthiaskrgr:rollup-exkviev, r=matth…
49b9cc5 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108319 (Don't project specializable RPITIT projection)
 - rust-lang#108364 (Unify validity checks into a single query)
 - rust-lang#108463 (bootstrap: Update the output of the `check` descriptions)
 - rust-lang#108477 (Make `match` arm comma suggestion more clear)
 - rust-lang#108486 (Merge diagnostic_items duplicate diagnostics)
 - rust-lang#108494 (Clean up JS files code a bit)
 - rust-lang#108500 (update Miri)
 - rust-lang#108502 (Don't trigger error for ReError when other region is empty.)
 - rust-lang#108513 (Remove `@nagisa` from review rotation)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2f6ba7b into rust-lang:master Feb 27, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@albertlarsan68 albertlarsan68

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

5 participants

@clubby789 @rustbot @albertlarsan68 @bors @compiler-errors