Skip to content

DO NOT REVIEW - WIP - 05 vec macroed #108150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 118 commits into from
Closed

DO NOT REVIEW - WIP - 05 vec macroed #108150

wants to merge 118 commits into from

Conversation

@peter-lyons-kehl
Copy link
Contributor

@peter-lyons-kehl peter-lyons-kehl commented Feb 17, 2023

Work in progress. Instead of #107607.
r? peter-kehl

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2023

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@peter-lyons-kehl peter-lyons-kehl marked this pull request as draft February 17, 2023 02:02
@peter-lyons-kehl peter-lyons-kehl mentioned this pull request Feb 17, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@peter-lyons-kehl peter-lyons-kehl mentioned this pull request Feb 19, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@peter-lyons-kehl
START CoAlloc API
619198d
@peter-lyons-kehl
CoAlloc: RawVec + compiler 'tests'
0b47315
@peter-lyons-kehl
CoAlloc: GlobalAlloc API
53028b7
@peter-lyons-kehl
CoAlloc: Alloc API
5539899
@peter-lyons-kehl
CoAlloc: RawVec includes GlobalCoAllocMeta based on allocator; relate…
0625fae 
…d bounds - NOT COMPILING (no ICE, but standard compiler error)
@peter-lyons-kehl
CoAlloc: VecDeque (PROBABLY NOT COMPILING, standard error)
4ddafb9
@peter-lyons-kehl
CoAlloc: RawVec + Vec with COOP_PREFERRED. PROBABLY NOT COMPILING, bu…
4d3b575 
…t no ICE.
@peter-lyons-kehl
VecDeque with COOP_PREFERRED. PROBABLY NOT COMPILING, but no ICE.
c96efc4
@peter-lyons-kehl
CoAlloc: RawVec, Vec, Box uses bounds. ICE
fb1e72f
@peter-lyons-kehl
CoAlloc: BinaryHeap now uses bounds. (Probably needs to go together w…
7450192 
…ith Vec). ICE
@peter-lyons-kehl
CoAlloc: VecDeque now uses bounds. ICE
3fb632e
@peter-lyons-kehl
CoAlloc: VecDeque. Probably ICE.
01599b9
@peter-lyons-kehl
CoAlloc: Vec + Slice. ICE
7e858bd
@peter-lyons-kehl
CoAlloc: VecDeque. ICE
8b1fbce
@peter-lyons-kehl
CoAlloc: Minor
0ec3f92
@peter-lyons-kehl
CoAlloc: library/alloc now uses macros, and no ICE. But meta_num_slot…
826786a 
…s macro is hardcoded - TO FIX.
@peter-lyons-kehl
CoAlloc: Using macros for config + transformations. WIP
16f13bb
@peter-lyons-kehl
CoAlloc: (Some) Separation of co-alloc-aware traits & methods.
6afb0d6
@peter-lyons-kehl
CoAlloc: Undoing generalizations + splitting. WIP
b20534f
@peter-lyons-kehl
CoAlloc: slice::to_vec_co, slice::to_vec_in_co.
b231c87
@peter-lyons-kehl
CoAlloc: Separated Vec::from_raw_parts_co and similar (and also in Ve…
b1c8971 
…cDeque). Mostly compiling.
@peter-lyons-kehl
CoAlloc: tidy
053a4b9
@peter-lyons-kehl
CoAlloc: Fixed my buggy rebase. Added slice::SpecCloneIntoVecCo and f…
68dc9e4 
…ixed Vec::clone_from.
@peter-lyons-kehl
CoAlloc: Default for Vec - both coallocation-aware (default fn), and …
819d4e1 
…'standard'.
@peter-lyons-kehl
CoAlloc: VecDeque: new_co, with_capacity_co, made default() coallocat…
bd1f71b 
…ion-friendly.
@peter-lyons-kehl
CoAlloc: tidy
20eded1
@peter-lyons-kehl
CoAlloc: Fixed previous sick result of: tidy --bless
fd11520
@peter-lyons-kehl
CoAlloc: slice::into_vec_co - for vec![...].
43d25dd
@peter-lyons-kehl
CoAlloc: compiler/rustc_arena: specialization; using Allocator::CoAll…
b76c63d 
…ocMeta in rustc validations.
@peter-lyons-kehl
CoAlloc: Unspecialized and specialized Box<[T]>::from(Vec) and Vec::f…
896f3dc 
…rom(Box<[T>]), so it works with legacy code.
@peter-lyons-kehl
CoAlloc: Fixed specializations
388ba85
@peter-lyons-kehl
CoAlloc: Fixes
b9f350c
@peter-lyons-kehl
Limited working around rust-lang/rust issue rust-lang#106473.
08e675a
@peter-lyons-kehl
CoAlloc: tidy
319b888
@peter-lyons-kehl
CoAlloc: bless
8caa109
@peter-lyons-kehl
CoAlloc: Working around a fmt bug
9fc9cd9
@peter-lyons-kehl
CoAlloc: Removed/split CO_ALLOC_PREF. Fixed tests
18d9361
@peter-lyons-kehl
CoAlloc: FIXME: raw_vec::assert_alignment()
5bbf264
@peter-lyons-kehl
CoAlloc: tidy
a84b78c
@peter-lyons-kehl
CoAlloc: Added CO_ALLOC_PREF to two Guard structs inside vec_deque::i…
1d47474 
…nto_iter
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Feb 19, 2023

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@peter-lyons-kehl peter-lyons-kehl mentioned this pull request Feb 20, 2023
Closed
@peter-lyons-kehl
Copy link
Contributor Author

peter-lyons-kehl commented Feb 20, 2023

Replaced by #108274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@peter-lyons-kehl peter-lyons-kehl

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peter-lyons-kehl @rustbot @rust-log-analyzer