-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Remove ResumeTy
from async lowering
#107562
base: master
Are you sure you want to change the base?
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
I'm gonna mark this as blocked for now @rustbot blocked |
☔ The latest upstream changes (presumably #108159) made this pull request unmergeable. Please resolve the merge conflicts. |
304d235
to
e92f4f1
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #116958) made this pull request unmergeable. Please resolve the merge conflicts. |
aa9f535
to
90ef563
Compare
I rebased this again after all the changes to coroutines and gen blocks. The failing test in |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #119174) made this pull request unmergeable. Please resolve the merge conflicts. |
90ef563
to
7907249
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #116520) made this pull request unmergeable. Please resolve the merge conflicts. |
7907249
to
4fd5a13
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #122045) made this pull request unmergeable. Please resolve the merge conflicts. |
4fd5a13
to
e270344
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #126784) made this pull request unmergeable. Please resolve the merge conflicts. |
Instead of using the stdlib supported `ResumeTy`, which is being converting to a `&mut Context<'_>` during the Generator MIR pass, this will use `&mut Context<'_>` directly in HIR lowering. It pretty much reverts rust-lang#105977 and re-applies an updated version of rust-lang#105250. This still fails the testcase added in rust-lang#106264 however, for reasons I don’t understand.
e270344
to
b684ee7
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #129873) made this pull request unmergeable. Please resolve the merge conflicts. |
Instead of using the stdlib supported
ResumeTy
, which is being converting to a&mut Context<'_>
during the Generator MIR pass, this will use&mut Context<'_>
directly in HIR lowering.It pretty much reverts #105977 and re-applies an updated version of #105250.
This still fails the testcase added in #106264 however, for reasons I don’t understand.
Is blocked on:
(Bogus
higher-ranked lifetime error
in an async block #102211)