-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Bump bootstrap compiler to 1.68 #107297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bootstrap compiler to 1.68 #107297
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -318,15 +318,27 @@ impl Config { | |
let channel = format!("{version}-{date}"); | ||
|
||
let host = self.build; | ||
let rustfmt_path = self.initial_rustc.with_file_name(exe("rustfmt", host)); | ||
let bin_root = self.out.join(host.triple).join("stage0"); | ||
let bin_root = self.out.join(host.triple).join("rustfmt"); | ||
let rustfmt_path = bin_root.join("bin").join(exe("rustfmt", host)); | ||
Comment on lines
-321
to
+322
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This broke the rust-analyzer config we suggest in the dev-guide: https://rustc-dev-guide.rust-lang.org/building/suggested.html#configuring-rust-analyzer-for-rustc "rust-analyzer.rustfmt.overrideCommand": [
"./build/host/stage0/bin/rustfmt",
"--edition=2021"
], since now rustfmt is in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's because we can't install multiple There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #107547 for more discussion. |
||
let rustfmt_stamp = bin_root.join(".rustfmt-stamp"); | ||
if rustfmt_path.exists() && !program_out_of_date(&rustfmt_stamp, &channel) { | ||
return Some(rustfmt_path); | ||
} | ||
|
||
let filename = format!("rustfmt-{version}-{build}.tar.xz", build = host.triple); | ||
self.download_component(DownloadSource::Dist, filename, "rustfmt-preview", &date, "stage0"); | ||
self.download_component( | ||
DownloadSource::Dist, | ||
format!("rustfmt-{version}-{build}.tar.xz", build = host.triple), | ||
"rustfmt-preview", | ||
&date, | ||
"rustfmt", | ||
); | ||
self.download_component( | ||
DownloadSource::Dist, | ||
format!("rustc-{version}-{build}.tar.xz", build = host.triple), | ||
"rustc", | ||
&date, | ||
"rustfmt", | ||
); | ||
|
||
self.fix_bin_or_dylib(&bin_root.join("bin").join("rustfmt")); | ||
self.fix_bin_or_dylib(&bin_root.join("bin").join("cargo-fmt")); | ||
|
Uh oh!
There was an error while loading. Please reload this page.