- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Rollup of 9 pull requests #107240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            Rollup of 9 pull requests #107240
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Parse `-> Ty | OtherTy`. Parse type ascription in top level patterns.
Suggest using a lock instead.
…not `usize::from().unwrap_unchecked()`. `usize::from()` gives a `usize`, not `Result<usize>`, and `usize: From<isize>` is not implemented.
Improve proc macro attribute diagnostics Closes rust-lang#102923
…r=compiler-errors Suggest coercion of `Result` using `?` Fix rust-lang#47560.
…tic, r=WaffleLapkin Suggest using a lock for `*Cell: Sync` bounds I mostly did this for `OnceCell<T>` at first because users will be confused to see that the `OnceCell<T>` in `std` isn't `Sync` but then extended it to `Cell<T>` and `RefCell<T>` as well.
Teach parser to understand fake anonymous enum syntax Parse `Ty | OtherTy` in function argument and return types. Parse type ascription in top level patterns. Minimally address rust-lang#100741.
…i-obk Custom MIR: Support binary and unary operations Lower binary and unary operations directly to corresponding unchecked MIR operations. Ultimately this might not be syntax we want, but it allows for experimentation in the meantime. r? ``@oli-obk`` ``@JakobDegen``
…, r=albertlarsan68 Print PID holding bootstrap build lock on Linux Partially address rust-lang#107077 Parse `/proc/locks` to find the PID of the process which created the build directory lock
…ush, r=estebank Fix escaping inference var ICE in `point_at_expr_source_of_inferred_type` Fixes rust-lang#107158 `point_at_expr_source_of_inferred_type` uses `lookup_probe` to adjust the self type of a method receiver -- but that method returns inference variables from inside a probe. That means that the ty vars are no longer valid, so we can't use any infcx methods on them. Also, pass some extra span info to hack a quick solution to bad labels, resulting in this diagnostic improvement: ```rust fn example2() { let mut x = vec![1]; x.push(""); } ``` ```diff error[E0308]: mismatched types --> src/main.rs:5:12 | 5 | x.push(""); | ---- ^^ | | | | | expected integer, found `&str` - | | this is of type `&'static str`, which causes `x` to be inferred as `Vec<{integer}>` | arguments to this method are incorrect ``` (since that "which causes `x` to be inferred as `Vec<{integer}>` part is wrong) r? `@estebank` (we really should make this code better in general, cc rust-lang#106590, but that's a bit bigger issue that needs some more thinking about)
…apkin `sub_ptr()` is equivalent to `usize::try_from().unwrap_unchecked()`, not `usize::from().unwrap_unchecked()` `usize::from()` gives a `usize`, not `Result<usize>`, and `usize: From<isize>` is not implemented.
…mpiler-errors `new_outside_solver` -> `evaluate_root_goal` r? `@rust-lang/initiative-trait-system-refactor`
| @bors r+ rollup=never p=9 | 
| ⌛ Testing commit 7c055af with merge 39d48f175517432f2db36f2f44b2172c65f56736... | 
| 💔 Test failed - checks-actions | 
| cfg-related warnings in #107086, updated with a fix | 
| The job  Click to see the possible cause of the failure (guessed by this bot) | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-translation
  Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic 
  
    rollup
  A PR which is a rollup 
  
    S-waiting-on-review
  Status: Awaiting review from the assignee but also interested parties. 
  
    T-bootstrap
  Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    T-libs
  Relevant to the library team, which will review and decide on the PR/issue. 
  
    WG-trait-system-refactor
  The Rustc Trait System Refactor Initiative (-Znext-solver) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Successful merges:
Resultusing?#106583 (Suggest coercion ofResultusing?)*Cell: Syncbounds #106944 (Suggest using a lock for*Cell: Syncbounds)point_at_expr_source_of_inferred_type#107175 (Fix escaping inference var ICE inpoint_at_expr_source_of_inferred_type)sub_ptr()is equivalent tousize::try_from().unwrap_unchecked(), notusize::from().unwrap_unchecked()#107223 (sub_ptr()is equivalent tousize::try_from().unwrap_unchecked(), notusize::from().unwrap_unchecked())new_outside_solver->evaluate_root_goal#107227 (new_outside_solver->evaluate_root_goal)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup