Rename Ty::is_ty_infer -> Ty::is_ty_or_numeric_infer
#106754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in need_type_info.rs cc @lcnr |
lcnr
reviewed
Jan 12, 2023
There was a problem hiding this comment.
can you still mention infer in the name, maybe is_ty_or_numeric_infer?
I don't have a strong mental connection from var to inference variables and I don't expect people would search for var when needing this method.
r=me afterwards
r? @lcnr
|
☔ The latest upstream changes (presumably #106773) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
ty-infer-method-is-confusing
branch
from
fd3e586 to
2a43eeb
Compare
compiler-errors
changed the title
Ty::is_ty_infer -> Ty::is_ty_or_numeric_varTy::is_ty_infer -> `Ty::is_ty_or_numeric_infer
compiler-errors
force-pushed
the
ty-infer-method-is-confusing
branch
from
2a43eeb to
8e27211
Compare
compiler-errors
changed the title
Ty::is_ty_infer -> `Ty::is_ty_or_numeric_inferTy::is_ty_infer -> Ty::is_ty_or_numeric_infer
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…-confusing, r=lcnr Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer` Makes sure people are aware that they may have a type variable *or* an int/float variable. r? ``@oli-obk`` rust-lang#106322 (comment) but I could instead implement your solution, let me know. (This will conflict with rust-lang#106322 for now, ignore that 😄)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#106608 (Render missing generics suggestion verbosely) - rust-lang#106716 ([RFC 2397] Deny incorrect locations) - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - rust-lang#106782 (Ignore tests move in git blame) - rust-lang#106785 (Make blame spans better for impl wfcheck) - rust-lang#106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#106608 (Render missing generics suggestion verbosely) - rust-lang#106716 ([RFC 2397] Deny incorrect locations) - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - rust-lang#106782 (Ignore tests move in git blame) - rust-lang#106785 (Make blame spans better for impl wfcheck) - rust-lang#106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure people are aware that they may have a type variable or an int/float variable.
r? @oli-obk #106322 (comment) but I could instead implement your solution, let me know.
(This will conflict with #106322 for now, ignore that 😄)