Skip to content

Emit a single error for contiguous sequences of unknown tokens #106566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

Emit a single error for contiguous sequences of unknown tokens #106566

merged 1 commit into from
Jan 14, 2023

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 7, 2023 •
edited
Loading

Closes #106101

On encountering a sequence of identical source characters which are unknown tokens, note the amount of subsequent characters and advance past them silently. The old behavior was to emit an error and 'help' note for every single one.

@rustbot label +A-diagnostics +A-parser

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The lexing & parsing of Rust source code to an AST labels Jan 7, 2023
@clubby789
Copy link
Contributor Author

clubby789 commented Jan 7, 2023 •
edited
Loading

@rustbot ready

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2023
@clubby789 clubby789 force-pushed the contiguous-weird-unicode branch from d0e5410 to 3296e62 Compare January 7, 2023 17:37
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
fmease
fmease reviewed Jan 8, 2023
View reviewed changes
@clubby789 clubby789 force-pushed the contiguous-weird-unicode branch from 3296e62 to e7b36ae Compare January 8, 2023 02:03
@cjgillot
Copy link
Contributor

r=me with @fmease's suggestion applied.

@clubby789 clubby789 force-pushed the contiguous-weird-unicode branch from e7b36ae to 3fd3322 Compare January 11, 2023 17:00
@fmease
Copy link
Member

fmease commented Jan 11, 2023

Thanks for applying my suggestion! @clubby789, you need to rebase onto current master for your PR to be mergeable (move tests from src/test/ to tests/ if git doesn't do it automatically).

@clubby789 clubby789 force-pushed the contiguous-weird-unicode branch from 3fd3322 to a3d6bc3 Compare January 12, 2023 00:16
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 14, 2023

📌 Commit a3d6bc3 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
@bors
Auto merge of rust-lang#106851 - matthiaskrgr:rollup-d9dz3yp, r=matth…
4b51adf 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#106046 (Fix mir-opt tests for big-endian platforms)
 - rust-lang#106470 (tidy: Don't include wasm32 in compiler dependency check)
 - rust-lang#106566 (Emit a single error for contiguous sequences of unknown tokens)
 - rust-lang#106644 (Update the wasi-libc used for the wasm32-wasi target)
 - rust-lang#106665 (Add note when `FnPtr` vs. `FnDef` impl trait)
 - rust-lang#106752 (Emit a hint for bad call return types due to generic arguments)
 - rust-lang#106788 (Tweak E0599 and elaborate_predicates)
 - rust-lang#106831 (Use GitHub yaml templates for ICE, Docs and Diagnostics tickets)
 - rust-lang#106846 (Improve some comments and names in parser)
 - rust-lang#106848 (Fix wrong path in triage bot autolabel for wg-trait-solver-refactor)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8e0eecd into rust-lang:master Jan 14, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 14, 2023
@dtolnay dtolnay mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@cjgillot cjgillot

Labels

A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The lexing & parsing of Rust source code to an AST S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

Too many errors on non-breaking space characters in source code

6 participants

@clubby789 @rustbot @rust-log-analyzer @cjgillot @fmease @bors