Skip to content

Tweak output for bare dyn Trait in arguments #105727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

Tweak output for bare dyn Trait in arguments #105727

merged 1 commit into from
Dec 16, 2022

Conversation

@estebank
Copy link
Contributor

Fix #35825.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2022
@estebank
Copy link
Contributor Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Dec 15, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 15, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 15, 2022

📌 Commit 124f194 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2022
@bors
Auto merge of rust-lang#105760 - matthiaskrgr:rollup-r8beo9w, r=matth…
7a6af27 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105481 (Start improving monomorphization items stats)
 - rust-lang#105674 (Point at method chains on `E0271` errors)
 - rust-lang#105679 (Suggest constraining type parameter with `Clone`)
 - rust-lang#105694 (Don't create dummy if val has escaping bounds var)
 - rust-lang#105727 (Tweak output for bare `dyn Trait` in arguments)
 - rust-lang#105739 (Migrate Jump to def links background to CSS variable)
 - rust-lang#105743 (`SimplifiedType` cleanups)
 - rust-lang#105758 (Move `TypeckResults` to separate module)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit abfad27 into rust-lang:master Dec 16, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 16, 2022
@estebank estebank deleted the use-impl-trait branch November 9, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

Using bare trait where not possible should suggest to use a trait object or generic bound

5 participants

@estebank @rustbot @oli-obk @bors @petrochenkov